Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad Monaco range in outline contribution #12306

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Fix bad Monaco range in outline contribution #12306

merged 1 commit into from
Mar 20, 2023

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #12304

How to test

  1. Outline functionality should work as expected.
  2. Following steps from MonacoOutlineContribution creates broken Range #12304 should not result in error logs about destructuring undefined.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the monaco issues related to monaco label Mar 14, 2023
msujew
msujew approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce the issue due to a lack of duplicate language servers, but the changes look pretty reasonable to me. So I'll approve this.

@colin-grant-work colin-grant-work merged commit afdae63 into eclipse-theia:master Mar 20, 2023
@colin-grant-work colin-grant-work added this to the 1.36.0 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
monaco issues related to monaco
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

MonacoOutlineContribution creates broken Range
2 participants
@colin-grant-work @msujew