Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fallback to applicationName #12265

Merged
merged 1 commit into from
Mar 8, 2023
Merged

core: fallback to applicationName #12265

merged 1 commit into from
Mar 8, 2023

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Mar 7, 2023

What it does

The commit adds handling to fallback to the applicationName when setting the window title which would previously display either index.html in electron or localhost:3000 in the browser.

Before:

Screen Shot 2023-03-07 at 3 40 20 PM

After:

Screen Shot 2023-03-07 at 3 38 43 PM

How to test

  1. for both the browser and electron example applications start the app without a workspace
  2. confirm that with views open the tab or window title relects the current widget (ex: getting started, preferences, keyboard shortcuts)
  3. close all open widgets
  4. the title should fallback to the applicationName
  5. confirm the behavior is correct with a workspace

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added core issues related to the core of the application ui/ux issues related to user interface / user experience labels Mar 7, 2023
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

packages/core/src/browser/window/window-title-service.ts Outdated Show resolved Hide resolved
The commit adds handling to fallback to the `applicationName` when setting the window title which would previously display either `index.html` in electron  or `localhost:3000` in the browser.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto merged commit 4ab3915 into master Mar 8, 2023
@github-actions github-actions bot added this to the 1.36.0 milestone Mar 8, 2023
@vince-fugnitto vince-fugnitto deleted the vf/appName branch March 8, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core issues related to the core of the application ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants