Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to toggle hidden folders/files in browser file dialog #12179

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

kenneth-marut-work
Copy link
Contributor

@kenneth-marut-work kenneth-marut-work commented Feb 13, 2023

What it does

Resolves #9215 by adding a toggle to show hidden folders and files in the browser's file dialog

image

How to test

  • Build this branch for browser
  • Open a save or open file dialog and test out the toggle
  • Does it work as expected?

Review checklist

Reminder for reviewers

@kenneth-marut-work kenneth-marut-work changed the title Draft: Show hidden files Option to toggle hidden folders/files in browser file dialog Feb 13, 2023
@colin-grant-work
Copy link
Contributor

Apart from the stray log, this is working well for me. 👍

protected override doRender(): React.ReactNode {
return (
<div className={TOGGLE_HIDDEN_CONTAINER_CLASS}>
Show hidden files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:
I believe we should localize the label if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the localization 👍

@vince-fugnitto vince-fugnitto added the file dialog issues related to the file dialog label Feb 14, 2023
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@colin-grant-work colin-grant-work merged commit a731a8d into master Feb 16, 2023
@github-actions github-actions bot added this to the 1.35.0 milestone Feb 16, 2023
@colin-grant-work colin-grant-work deleted the show-hidden-files branch February 16, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file dialog issues related to the file dialog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Hidden files option on browser Open/Save dialog
3 participants