fixes #12112 Removing exited thread from threads

[EvilBeaver]

What it does

Fixes #12112

How to test

Check that when multiple threads existed, and one of them exited - it removed from threads panel

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

[EvilBeaver]

@vince-fugnitto should I close this PR and recommit changes with a proper signature? I don't understand what I should do, sorry

[vince-fugnitto]

@vince-fugnitto should I close this PR and recommit changes with a proper signature? I don't understand what I should do, sorry

@EvilBeaver you don't need to modify or close the pull-request, just be sure to sign the agreement with the same email as authorship and we can re-run the eclipsefdn/eca CI check.

[EvilBeaver]

@vince-fugnitto I've created eclipse account and signed agreement. Hope I've done everything correct :)

[EvilBeaver]

@vince-fugnitto can you give any clues to why ubuntu tests could fail? It seems there's some external problem on build agents...

[vince-fugnitto]

@vince-fugnitto can you give any clues to why ubuntu tests could fail? It seems there's some external problem on build agents...

No problem, there is an issue tracking the ubuntu tests which execute our api test-suite as it is currently known to be flaky (#12081).

[EvilBeaver]

@vince-fugnitto thanks. Can I say that PR is fine and I shouldn't do anything else with it to have it merged?

[vince-fugnitto]

@vince-fugnitto thanks. Can I say that PR is fine and I shouldn't do anything else with it to have it merged?

Right, we just need to review the changes and confirm it is correct. I haven't had the time to look into it yet but I will try shortly.
@kittaakos would you like to take a look as well since it affects debug functionality?

[kittaakos]

Thanks for the heads-up, @vince-fugnitto 👍

I could not verify it with the HEAD of Theia, but I applied the change from this PR on 1.31.1, and the Marus/cortex-debug debugger still works in the Arduino IDE. For the record, I could not reproduce #12112 with the cortex-debug VS Code extension either.

[EvilBeaver]

I could not reproduce #12112 with the cortex-debug VS Code extension either.

To reproduce this, you'll need to have no threads debugged (all exited), but debug session still active. I'm not familiar with cortex-debug, but it's hard to achieve in node.js for example, cause it's usually single threaded.

[tsmaeder]

@kittaakos @vince-fugnitto ping. Can we either merge or close this one?

[kittaakos]

Can we either merge or close this one?

Thanks for the ping. Feel free to merge it. I can confirm, It does not cause any regression with the cortex-debug VSIX.

[tsmaeder]

@kittaakos @vince-fugnitto not without an approval ;-)

[kittaakos]

I tried the changeset (#12113 (comment)) by manually applying it in the Arduino IDE source code, and I can confirm it does not cause any problems with the cortex-debug VS Code extension.

Thanks for the work @EvilBeaver 💪

[vince-fugnitto]

@EvilBeaver do you mind rebasing the pull-request so we can run it against the latest CI state?

[EvilBeaver]

@EvilBeaver do you mind rebasing the pull-request so we can run it against the latest CI state?

updated to latest state of master branch

[vince-fugnitto]

LGTM 👍 I did not notice any regressions with the approach and agree with Akos.