Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization metadata update 1.68.1 #12092

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Localization metadata update 1.68.1 #12092

merged 3 commits into from
Jan 23, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Jan 20, 2023

What it does

As a follow-up to #12090, updates our translation file to align with the language packs downloaded by Theia for vscode API version 1.68.1.

How to test

  1. Assert that the lint CI is green (no accidental usage of localize/localizeByDefault)
  2. Opening the application in another language should show no warnings related to untranslated values

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Jan 20, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msujew msujew merged commit b597a04 into master Jan 23, 2023
@msujew msujew deleted the msujew/nls-update-1.68.1 branch January 23, 2023 15:09
@github-actions github-actions bot added this to the 1.34.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants