vscode: add support for valueSelection in InputBox

[jonah-iden]

Signed-off-by: Jonah Iden jonah.iden@typefox.io

What it does

Fixes: #12016.

it adds a new field to the InputBox with which a specific range of text from the InputBox can be slected

How to test

i build a small vscode extension for testing found here: https://github.com/jonah-iden/inputBox-ValueSelection-test
and as vsix value-selection-test-0.0.1.zip

it just opens up a input box which selects all text until the firs space character when the text is changed

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

Do you mind rebasing your changes to the latest master, just to have the theia.d.ts styling fixes out of the way.

[vince-fugnitto]

@jonah-iden please take a look at the linting errors due to missing semicolons: https://github.com/eclipse-theia/theia/actions/runs/3884942760/jobs/6628169768#step:6:832.

If you haven't already I'd suggest installing the dbaeumer.vscode-eslint extension which highlights eslint errors and warnings directly in the editor.

[paul-marechal]

Despite what the typings for the getter say, I believe that valueSelection can be undefined until someone explicitly sets it somehow. I'm also confused with how the setter accepts undefined wen the getter says it's always defined??

Please make sure it's all consistent.

edit: Apparently TypeScript is happy with different types between setters and getters, so I guess this part is fine?

[jonah-iden]

your totally right though. ValueSelection can be undefined until the setter is called. I think it was this way in the vs code code

[msujew]

Looks good to me 👍

• The API is marked as supported
• The extension works as expected

[jonah-iden]

if this PR is okay someone else would have to merge it since i don't have write access rights yet

[paul-marechal]

InputBox#valueSelection shouldn't be undefined according to the VS Code API.

edit: Turns out vscode.d.ts allows undefined but not the web documentation...