added a max height and overflow to select-dropdown #12038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto to the select-component-dropdown, so that the dropdown can't get bigger than the Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
reviewed
Jan 2, 2023
There was a problem hiding this comment.
Hey @jonah-iden, thanks for the first time contribution.
Please make sure to sign the Eclipse Contributor Agreement (ECA) with the same email that is associated with this commit for us to accept the changes.
msujew
reviewed
Jan 9, 2023
There was a problem hiding this comment.
When scrolling using the mouse wheel, the select component will automatically close due to this code. The hide function needs to be updated to detect whether the target element of the event is actually inside of the select component. If it is outside the component, it should close the dropdown and keep it open if the target is inside.
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
vince-fugnitto
added
core
msujew
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto to the select-component-dropdown,
so that the dropdown can't get bigger than the
Signed-off-by: Jonah Iden jonah.iden@typefox.io
What it does
Closes: #11991 .
Added a default "overflow: auto" and a max-height to the select-component dropdown. The max-height is calculated so that the dropdown is never outside of the visible area (clientRect).
How to test
Best way to test is probably adding a lot of debug configurations to the launch.json. Then in the debug window the configuration dropdown should on go to the bottom of the page and have a scrollbar.
For the inverted state i testet it thorugh the preferences (Terminal › Integrated: Font Weight Bold is a good select-box for that) by making the browser very small.
Review checklist
Reminder for reviewers