Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tab related APIs - without functionality implemented yet #12031

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Dec 29, 2022

What it does

It adds tab related APIs. For now it just solves the problem that we get an error when an extension uses the VSCode Tab API.
Functionality is not implemented on theia side yet.

How to test

  1. Download this test extension:
    tab-test-0.0.1.zip
    and change the file type from zip to vsix
    or create it here
    or use another extension which uses the VSCode Tab API
  2. install it in theia
  3. trigger the command 'Close Active Tab'
  4. see that nothing happens, even no errors notified anymore

Review checklist

Reminder for reviewers

@jbicker jbicker force-pushed the jbicker/vscode-add-tab-related-11692 branch from 1d3a31c to 4456d4a Compare December 29, 2022 10:41
@jbicker jbicker marked this pull request as ready for review December 29, 2022 10:42
@jbicker jbicker mentioned this pull request Dec 29, 2022
12 tasks
@jbicker jbicker changed the title Added tab related APIs Added tab related APIs - without functionality implemented yet Dec 29, 2022
@paulalexwilson
Copy link

https://github.com/jbicker/tab-api-test-extension is not accessible to me

@JonasHelming
Copy link
Contributor

This is great! Would you mind marking the members in theia.d.ts as @stubbed (see here for an example. This way, the stubbed members are showsn correctly as stubbed in the compat report (see here)

@jbicker
Copy link
Contributor Author

jbicker commented Dec 30, 2022

@paulalexwilson, sorry about that. Try again!

@jbicker jbicker force-pushed the jbicker/vscode-add-tab-related-11692 branch from 4456d4a to af866c7 Compare December 30, 2022 12:11
@jbicker
Copy link
Contributor Author

jbicker commented Dec 30, 2022

I squashed and force pushed with @stubbed markers.

@JonasHelming
Copy link
Contributor

@rschnekenbu Could you run the VS Code compat checker over this branch and see whether all members are shown as stubbed (or supported)?

@rschnekenbu
Copy link
Contributor

@JonasHelming, sure, I will run the tool tomorrow and give the result here

@rschnekenbu
Copy link
Contributor

All members related to 'Tab' API are shown as @stubbed or implemented in @jbicker branch. That looks good to me on that aspect.

report: status.zip

@jbicker jbicker merged commit dc89b73 into master Jan 4, 2023
@jbicker jbicker deleted the jbicker/vscode-add-tab-related-11692 branch January 4, 2023 13:55
@github-actions github-actions bot added this to the 1.34.0 milestone Jan 4, 2023
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants