Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewContainerLayout: remove moveWidget override #11576

Merged

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes a bug that breaks ViewContainerLayout.insertWidget by redundantly swapping items in the _widgets array.

How to test

To Confirm Bug
  1. Remove second (main) commit from this PR.
  2. Open the application and open the Navigator widget.
  3. Run the command Bug: Try to swap top two widgets in Navigator several times.
  4. The first invocation may work, but subsequent invocations will fail, and the widgets will stay in the same order.
To Confirm Fix
  1. Bring back the second (main) commit from this PR.
  2. Run steps above. All invocations should take effect, and the drop shadows on ViewContainerParts should be correct (none on top, shadow between subsequent views)
  3. Drag and drop widgets in ViewContainers.
  4. Behavior should be as on master, and drop shadows should be correct.
  5. With items in non-default positions, refresh the application.
  6. Positions should be restored correctly, and drop shadows should be correct.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the shell issues related to the core shell label Aug 16, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the bug on master, and that the change successfully fix the issue 👍
I did not notice any regressions when testing.

@colin-grant-work colin-grant-work merged commit 98a0bf6 into eclipse-theia:master Sep 6, 2022
@colin-grant-work colin-grant-work deleted the bugfix/move-widget branch September 6, 2022 21:01
@colin-grant-work colin-grant-work added this to the 1.30.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shell issues related to the core shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants