fix(application-package): Fix the return value error of electron.isDevMode API in Windows system in development mode. #10359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Nov 1, 2021
There was a problem hiding this comment.
Hi @zhaomenghuan, thank you for your contribution, do you mind adding testing steps to your PR?
Hi @msujew, I added a test description. |
msujew
approved these changes
Nov 1, 2021
paul-marechal
requested changes
Nov 9, 2021
zhaomenghuan
force-pushed
the
bugfix/electron-isDevMode
branch
from
41a260d to
d83434b
Compare
…vMode API in Windows system in development mode Signed-off-by: zhaomenghuan <zhaomenghuan02@meituan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fix the return value error of electron.isDevMode API in Windows system in development mode.
How to test
Run the Theia source code project based on the Windows system, then open DevTools to execute the following code：
Review checklist
Reminder for reviewers
Signed-off-by: zhaomenghuan zhaomenghuan02@meituan.com