Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement revert file command #10294

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Implement revert file command #10294

merged 1 commit into from
Oct 20, 2021

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Oct 18, 2021 •
edited
Loading

What it does

VSCode has a command to revert the open file. We recently added one to revert and close, so this borrows that logic to implement just reverting.

How to test

  1. Open a file in an editor and dirty it.
  2. Open the command palette and execute 'File: Revert File'.
  3. Your changes should be reverted and the editor should show as not dirty.

Review checklist

Reminder for reviewers

Signed-off-by: Colin Grant colin.grant@ericsson.com

@colin-grant-work colin-grant-work added editor issues related to the editor vscode issues related to VSCode compatibility commands issues related to application commands labels Oct 18, 2021
Implement revert file command
e872942 
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
vince-fugnitto
vince-fugnitto approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the pull-request works as expected:

  • the file can be successfully reverted when dirty
  • the behavior is consistent with that of vscode (id, enablement, naming...)

@colin-grant-work colin-grant-work merged commit f65e101 into master Oct 20, 2021
@colin-grant-work colin-grant-work deleted the feature/revert-command branch October 20, 2021 17:38
@github-actions github-actions bot added this to the 1.19.0 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
commands issues related to application commands editor issues related to the editor vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-grant-work @vince-fugnitto