Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for window.menuBarVisibility #9779

Closed
idoprz opened this issue Jul 27, 2021 · 1 comment · Fixed by #9830
Closed

add support for window.menuBarVisibility #9779

idoprz opened this issue Jul 27, 2021 · 1 comment · Fixed by #9830
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help

Comments

@idoprz
Copy link

idoprz commented Jul 27, 2021 •
edited by vince-fugnitto
Loading

Feature Description

The menu bar is not very useful for many users who uses keyboard shortcuts.
It would be great if Theia supported the preference window.menuBarVisibility as in vscode.

See example
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help labels Jul 27, 2021
@vince-fugnitto
Copy link
Member

Note that it would only work well for the browser use-case, unless we support window.titleBarStyle for electron (which uses the custom browser menu in electron).

EstherPerelman added a commit to EstherPerelman/theia that referenced this issue Aug 2, 2021
@EstherPerelman
Fix eclipse-theia#9779: add support for window.menuBarVisibility
a858109 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 3, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
d593b44 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
@ChayaLau ChayaLau mentioned this issue Aug 3, 2021
Merged
1 task
EstherPerelman added a commit to EstherPerelman/theia that referenced this issue Aug 4, 2021
@EstherPerelman
Fix eclipse-theia#9779: add support for window.menuBarVisibility
667abcd 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 5, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
3ff1351 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 5, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
9581076 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 9, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
d3b918a 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 9, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
b7de7ab 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 9, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
53e9536 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 11, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
ee678b4 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 11, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
aa33d1a 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 11, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
378cd19 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 12, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
16f7624 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 12, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
384a7ab 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 15, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
20da195 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 17, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
cd4e250 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
EstherPerelman added a commit to EstherPerelman/theia that referenced this issue Aug 19, 2021
@EstherPerelman
Fix eclipse-theia#9779: add support for window.menuBarVisibility
18c87d7 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 19, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
24dc613 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau pushed a commit to EstherPerelman/theia that referenced this issue Aug 22, 2021
@EstherPerelman @ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
ca77ffb 
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
ChayaLau added a commit to EstherPerelman/theia that referenced this issue Aug 22, 2021
@ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
d0892bc 
Signed-off-by: ChayaLau <chaya.lau@sap.com>
ChayaLau added a commit to EstherPerelman/theia that referenced this issue Aug 24, 2021
@ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
e460297 
Signed-off-by: ChayaLau <chaya.lau@sap.com>
ChayaLau added a commit to EstherPerelman/theia that referenced this issue Aug 24, 2021
@ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
bd6c5e1 
Signed-off-by: ChayaLau <chaya.lau@sap.com>
ChayaLau added a commit to EstherPerelman/theia that referenced this issue Aug 24, 2021
@ChayaLau
Fix eclipse-theia#9779: add support for window.menuBarVisibility
465e7be 
Signed-off-by: ChayaLau <chaya.lau@sap.com>
paul-marechal pushed a commit that referenced this issue Aug 26, 2021
@ChayaLau
Fix #9779: add support for window.menuBarVisibility (#9830)
6f80dc1 
Signed-off-by: ChayaLau <chaya.lau@sap.com>
RomanNikitenko pushed a commit that referenced this issue Sep 16, 2021
@ChayaLau @RomanNikitenko
Fix #9779: add support for window.menuBarVisibility (#9830)
201c321 
Signed-off-by: ChayaLau <chaya.lau@sap.com>
RomanNikitenko pushed a commit that referenced this issue Sep 16, 2021
@ChayaLau @RomanNikitenko
Fix #9779: add support for window.menuBarVisibility (#9830)
dbfdcff 
Signed-off-by: ChayaLau <chaya.lau@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #9779: add support for window.menuBarVisibility EstherPerelman/theia
2 participants
@idoprz @vince-fugnitto