Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Keybinding, KeybindingContribution and KeybindingRegistry #8636

Closed
JonasHelming opened this issue Oct 15, 2020 · 0 comments · Fixed by #8637
Closed

Add documentation for Keybinding, KeybindingContribution and KeybindingRegistry #8636

JonasHelming opened this issue Oct 15, 2020 · 0 comments · Fixed by #8637
Labels
documentation issues related to documentation keybindings issues related to keybindings

Comments

@JonasHelming
Copy link
Contributor

KeybindingContribution is expected to be used by extensions, KeybindingRegistry is a central service to interact with. So adopters would benefit from more documentation on these entities.
I will submit a contribution
JonasHelming added a commit to eclipsesource/theia that referenced this issue Oct 15, 2020
@JonasHelming
Added documentation for key binding, contributions and registry
e138002 
fixes eclipse-theia#8636

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming JonasHelming mentioned this issue Oct 15, 2020
Merged
1 task
@vince-fugnitto vince-fugnitto added documentation issues related to documentation keybindings issues related to keybindings labels Oct 15, 2020
JonasHelming added a commit to eclipsesource/theia that referenced this issue Oct 20, 2020
@JonasHelming
Added documentation for key binding, contributions and registry
728a8f5 
fixes eclipse-theia#8636

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
JonasHelming added a commit to eclipsesource/theia that referenced this issue Oct 20, 2020
@JonasHelming
Added documentation for key binding, contributions and registry
1cda047 
fixes eclipse-theia#8636

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
vince-fugnitto pushed a commit that referenced this issue Oct 22, 2020
@JonasHelming @vince-fugnitto
Added documentation for key binding, contributions and registry
4f3faa0 
fixes #8636

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
EstherPerelman pushed a commit to EstherPerelman/theia that referenced this issue Oct 29, 2020
@JonasHelming @EstherPerelman
Added documentation for key binding, contributions and registry
cfa30c5 
fixes eclipse-theia#8636

Contributed on behalf of STMicroelectronics

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation issues related to documentation keybindings issues related to keybindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add documentation for Keybinding, KeybindingContribution and KeybindingRegistry eclipsesource/theia
2 participants
@JonasHelming @vince-fugnitto