Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add order property to SubMenuOptions #7958

Closed
Hanksha opened this issue Jun 4, 2020 · 7 comments · Fixed by #7963
Closed

Add order property to SubMenuOptions #7958

Hanksha opened this issue Jun 4, 2020 · 7 comments · Fixed by #7963
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves menus issues related to the menu

Comments

@Hanksha
Copy link
Contributor

Hanksha commented Jun 4, 2020

Currently it's not possible to manage the order of sub menus like menu actions via the order property. I'd like to add the order property to SubMenuOptions so it can be sorted with the menu actions.

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help menus issues related to the menu labels Jun 4, 2020
@Hanksha
Copy link
Contributor Author

Hanksha commented Jun 4, 2020

I'll start working on it.

@vince-fugnitto
Copy link
Member

I'll start working on it.

Thank you for taking care of it!
Is it a duplicate of #6768? I'm asking only so we can successfully close both issues (or keep one open so we can track it).

@Hanksha
Copy link
Contributor Author

Hanksha commented Jun 4, 2020

@vince-fugnitto yes it would fix that ticket as well, although I'm not entirely sure it will fix everything mentioned on that ticket (changing the order of existing sub menus).

@vince-fugnitto
Copy link
Member

@vince-fugnitto yes it would fix that ticket as well, although I'm not entirely sure it will fix everything mentioned on that ticket (changing the order of existing sub menus).

I don't think the idea is to update existing menu items, I think the idea is to support an optional order property which when defined will be used to sort menu items instead of by their id (segment of the menu path).

@Hanksha
Copy link
Contributor Author

Hanksha commented Jun 4, 2020

Ok you can close this issue as duplicate then.

@vince-fugnitto
Copy link
Member

Ok you can close this issue as duplicate then.

I'll close the older one since we had discussions here, and you've assigned it to yourself :)

@Hanksha
Copy link
Contributor Author

Hanksha commented Jun 4, 2020

Alright!

@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Jun 4, 2020
Hanksha pushed a commit to Hanksha/theia that referenced this issue Jun 4, 2020
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
Hanksha pushed a commit to Hanksha/theia that referenced this issue Jun 4, 2020
Hanksha pushed a commit to Hanksha/theia that referenced this issue Jun 4, 2020
Hanksha pushed a commit to Hanksha/theia that referenced this issue Jun 4, 2020
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
Hanksha added a commit to Hanksha/theia that referenced this issue Jun 4, 2020
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
akosyakov pushed a commit that referenced this issue Jun 5, 2020
Signed-off-by: Vivien Jovet <vivien.jovet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves menus issues related to the menu
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants