Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search preview is missing trailing whitespaces #5987

Closed
AlexTugarev opened this issue Aug 19, 2019 · 0 comments · Fixed by #5989
Closed

Search preview is missing trailing whitespaces #5987

AlexTugarev opened this issue Aug 19, 2019 · 0 comments · Fixed by #5989
Labels
bug bugs found in the application search in workspace issues related to the search-in-workspace

Comments

@AlexTugarev
Copy link
Contributor

try to search for "something " where the trailing space is matched as well,
e.g. something something.

currently, the preview including the highlighted search string will remove the trailing whitespace,
e.g. somethingsomething

this is a bit annoying when it comes to preview of replacements.
@AlexTugarev AlexTugarev added bug bugs found in the application search in workspace issues related to the search-in-workspace labels Aug 19, 2019
vince-fugnitto added a commit that referenced this issue Aug 19, 2019
@vince-fugnitto
Display leading and trailing whitespaces in search-in-workspace results
0997e54 
Fixes #5987

- fixed an issue where leading and trailing whitespaces were not being displayed
from the `search-in-workspace` result tree leading to confusion and overall an
annoying behavior.
- added an additional test to `ripgrep-search-in-workspace-server.slow-spec.ts` which
tests the result of a search including a trailing whitespace.
- added an additional test to `ripgrep-search-in-workspace-server.slow-spec.ts` which
tests the result of a search including a leading whitespace.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Aug 19, 2019
Merged
1 task
vince-fugnitto added a commit that referenced this issue Aug 20, 2019
@vince-fugnitto
Display leading and trailing whitespaces in search-in-workspace results
acb4fff 
Fixes #5987

- fixed an issue where leading and trailing whitespaces were not being displayed
from the `search-in-workspace` result tree leading to confusion and overall an
annoying behavior.
- added an additional test to `ripgrep-search-in-workspace-server.slow-spec.ts` which
tests the result of a search including a trailing whitespace.
- added an additional test to `ripgrep-search-in-workspace-server.slow-spec.ts` which
tests the result of a search including a leading whitespace.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Aug 20, 2019
@vince-fugnitto
Display leading and trailing whitespaces in search-in-workspace results
70c68a2 
Fixes #5987

- fixed an issue where leading and trailing whitespaces were not being displayed
from the `search-in-workspace` result tree leading to confusion and overall an
annoying behavior.
- added an additional test to `ripgrep-search-in-workspace-server.slow-spec.ts` which
tests the result of a search including a trailing whitespace.
- added an additional test to `ripgrep-search-in-workspace-server.slow-spec.ts` which
tests the result of a search including a leading whitespace.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display leading and trailing whitespaces in search-in-workspace results eclipse-theia/theia
1 participant
@AlexTugarev