Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] support editor/title context menus for web views #5515

Closed
502647092 opened this issue Jun 19, 2019 · 1 comment · Fixed by #6030
Closed

[vscode] support editor/title context menus for web views #5515

502647092 opened this issue Jun 19, 2019 · 1 comment · Fixed by #6030
Labels
bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility webviews issues related to webviews

Comments

@502647092
Copy link
Contributor

502647092 commented Jun 19, 2019

Description

preview toolbar also not support
VSCode
image
Theia
image

Reproduction Steps

Download vscode plugin REST Client(humao.rest-client)
create a new http file
Send Request
look response

OS and Theia version:
Diagnostics:

@502647092 502647092 changed the title [vscode] plugin preview window not support color [vscode] plugin preview window incomplete support Jun 19, 2019
@akosyakov akosyakov added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility webviews issues related to webviews labels Jun 19, 2019
@akosyakov akosyakov changed the title [vscode] plugin preview window incomplete support [vscode] support editor/title context menus for web views Jun 19, 2019
@akosyakov
Copy link
Member

These actions are contributed via editor/title contribution point for the webview: https://github.com/Huachao/vscode-restclient/blob/ea54abe5e5e54eccd002dbef7ff1693d48983f9d/package.json#L205-L236

The difference between Theia and VS Code is that everything visible in the main area is an editor for VS Code from the perspective of commands and contribution points. In Theia an editor is an textual editor. Right now it's only possible to contribute menu items to textual editor because of it. We should rather base the check on whether a widget is a navigatable or not, i.e. it backed up by a file resource.

@eclipse-theia eclipse-theia deleted a comment from 502647092 Jun 19, 2019
@akosyakov akosyakov added the bug bugs found in the application label Jun 19, 2019
akosyakov added a commit that referenced this issue Jun 19, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jun 19, 2019
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
2 participants