Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] handle keybindings in upper-case #4175

Closed
akosyakov opened this issue Jan 28, 2019 · 0 comments · Fixed by #4202
Closed

[vscode] handle keybindings in upper-case #4175

akosyakov opened this issue Jan 28, 2019 · 0 comments · Fixed by #4202
Assignees
@akosyakov
Labels
enhancement issues that are enhancements to current functionality - nice to haves keybindings issues related to keybindings vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

VS Code normalizes keybindings to lower-case and trim them before parsing. We should do the same.

screen shot 2019-01-28 at 13 34 02
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves keybindings issues related to keybindings vscode issues related to VSCode compatibility labels Jan 28, 2019
@akosyakov akosyakov mentioned this issue Jan 28, 2019
Closed
@akosyakov akosyakov self-assigned this Jan 31, 2019
akosyakov added a commit that referenced this issue Jan 31, 2019
@akosyakov
[vscode] fix #4175: tolerate mistyped keybindings
6d7db30 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Jan 31, 2019
Merged
akosyakov added a commit that referenced this issue Feb 1, 2019
@akosyakov
[vscode] fix #4175: tolerate mistyped keybindings
0628cb3 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
enhancement issues that are enhancements to current functionality - nice to haves keybindings issues related to keybindings vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] tolerate mistyped keybindings eclipse-theia/theia
1 participant
@akosyakov