Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace.onDidRenameFile and workspace.onWillRenameFile implementations are missed #4167

Closed
tolusha opened this issue Jan 25, 2019 · 1 comment
Closed

workspace.onDidRenameFile and workspace.onWillRenameFile implementations are missed #4167

tolusha opened this issue Jan 25, 2019 · 1 comment
Assignees
@vrubezhny
Labels
plug-in system issues related to the plug-in system typescript issues related to the typescript language vscode issues related to VSCode compatibility

Comments

@tolusha
Copy link
Contributor

tolusha commented Jan 25, 2019

The goal of this task is to add missed parts [1] to have ability to use VS Code typescript extension [2] as a .theia plugin in Eclipse Che. workspace.onDidRenameFile and workspace.onWillRenameFile are not part of extension API.

[1] https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.proposed.d.ts#L1033-L1035
[2] https://github.com/Microsoft/vscode/tree/master/extensions/typescript-language-features

Reference issue

#3767
@tolusha tolusha added typescript issues related to the typescript language plug-in system issues related to the plug-in system labels Jan 25, 2019
@tsmaeder tsmaeder mentioned this issue Jan 25, 2019
Closed
30 tasks
@tolusha tolusha mentioned this issue Jan 25, 2019
Merged
@tolusha
Copy link
Contributor Author

tolusha commented Feb 6, 2019

Methods are stubbed, implementations are needed.

@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label Feb 6, 2019
@tsmaeder tsmaeder mentioned this issue Feb 8, 2019
Closed
20 tasks
@tsmaeder tsmaeder mentioned this issue Feb 27, 2019
Closed
18 tasks
@vrubezhny vrubezhny mentioned this issue Mar 4, 2019
Merged
vrubezhny added a commit that referenced this issue Mar 11, 2019
@vrubezhny
workspace.onDidRenameFile and workspace.onWillRenameFile implementati…
15a3b34 
…ons are missed #4167

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrubezhny vrubezhny

Labels
plug-in system issues related to the plug-in system typescript issues related to the typescript language vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vrubezhny @tolusha @tsmaeder