[inversify] Error in construction injection #2451
Assignees
Labels
bug
bugs found in the application
Comments
|
it's related to es6! closing this and targeting PR for #2443. |
AlexTugarev
added a commit
that referenced
this issue
Jul 26, 2018
…ed to es6 (Object.keys) see #2451 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
akosyakov
pushed a commit
that referenced
this issue
Jul 27, 2018
…ed to es6 (Object.keys) see #2451 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
akosyakov
pushed a commit
that referenced
this issue
Jul 27, 2018
…ed to es6 (Object.keys) see #2451 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
akosyakov
pushed a commit
that referenced
this issue
Jul 31, 2018
…ed to es6 (Object.keys) see #2451 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
akosyakov
pushed a commit
that referenced
this issue
Jul 31, 2018
…ed to es6 (Object.keys) see #2451 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
marcdumais-work
pushed a commit
to marcdumais-work/theia
that referenced
this issue
Oct 15, 2018
…ed to es6 (Object.keys) see eclipse-theia#2451 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It turns out that the construction injection has an important limitation. Subclasses should not add more dependencies as constructor arguments. It's even worse, inversify will plan to inject n arguments of sub's constructor, where n is the number of super constructor arguments, which is silly if you rearrange them in sub.
Injection fails in
class FrontendConnectionStatusService extends AbstractConnectionStatusServicefor instance.The text was updated successfully, but these errors were encountered: