Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[electron] Error: Possible Emitter memory leak detected #2208

Closed
MarkZ3 opened this issue Jun 27, 2018 · 1 comment
Closed

[electron] Error: Possible Emitter memory leak detected #2208

MarkZ3 opened this issue Jun 27, 2018 · 1 comment

Comments

@MarkZ3
Copy link
Contributor

MarkZ3 commented Jun 27, 2018

Theia master as of (603fe22), Electron example.

[2018-06-27T13:43:31.978Z] WARN: Theia/10545 on elxajvlvvz1: (logger=root)
Error: Possible Emitter memory leak detected. 30 exit listeners added. Use event.maxListeners to increase limit
at Emitter.../../packages/core/lib/common/event.js.Emitter.checkMaxListeners (file:///home/user/git/stable-dev/theia/examples/electron/lib/bundle.js:148920:26)
at PreferenceServiceImpl._event.Object.assign.maxListeners [as onPreferenceChanged] (file:///home/user/git/stable-dev/theia/examples/electron/lib/bundle.js:148887:27)
at ElectronMainMenuFactory.../../packages/core/lib/electron-browser/menu/electron-main-menu-factory.js.ElectronMainMenuFactory.fillMenuTemplate (file:///home/user/git/stable-dev/theia/examples/electron/lib/bundle.js:152110:33)
at _loop_1 (file:///home/user/git/stable-dev/theia/examples/electron/lib/bundle.js:152064:28)
at ElectronMainMenuFactory.../../packages/core/lib/electron-browser/menu/electron-main-menu-factory.js.ElectronMainMenuFactory.fillMenuTemplate (file:///home/user/git/stable-dev/theia/examples/electron/lib/bundle.js:152100:17)
at ElectronMainMenuFactory.../../packages/core/lib/electron-browser/menu/electron-main-menu-factory.js.ElectronMainMenuFactory.createContextMenu (file:///home/user/git/stable-dev/theia/examples/electron/lib/bundle.js:152043:29)
at ElectronContextMenuRenderer.../../packages/core/lib/electron-browser/menu/electron-context-menu-renderer.js.ElectronContextMenuRenderer.render (file:///home/user/git/stable-dev/theia/examples/electron/lib/bundle.js:151955:37)
at MonacoContextMenuService.../../packages/monaco/lib/browser/monaco-context-menu.js.MonacoContextMenuService.showContextMenu (file:///home/user/git/stable-dev/theia/examples/electron/lib/bundle.js:177484:38)
at ContextMenuController._doShowContextMenu (file:///home/user/git/stable-dev/theia/examples/electron/lib/vs/editor/editor.main.js:78999:38)

@MarkZ3
Copy link
Contributor Author

MarkZ3 commented Jul 11, 2018

Please note that you have to use a different command now to see the logging, see #2344

paul-marechal added a commit that referenced this issue Jul 26, 2018
`electron-main-menu-factory` was registering a lot of listeners.
This commit refactors the listeners into one, reducing the count and avoiding the error.

Fix #2208.

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
marcdumais-work pushed a commit to marcdumais-work/theia that referenced this issue Oct 15, 2018
`electron-main-menu-factory` was registering a lot of listeners.
This commit refactors the listeners into one, reducing the count and avoiding the error.

Fix eclipse-theia#2208.

Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant