Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] workspace registerFileSystemProvider options can explain why FS is readonly with 1.86 #13353

Closed
Tracked by #13356
rschnekenbu opened this issue Feb 6, 2024 · 3 comments · Fixed by #13414
Closed
Tracked by #13356
Assignees
Labels
vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

With vscode 1.86, workspace.registerFileSystemProvider() readonly option can now be a markdown string to explain why the file system is readonly.

see https://github.com/microsoft/vscode/blob/e5447598324c57ac814c150148e7e4c830e0f9ee/src/vscode-dts/vscode.d.ts#L13663

@rschnekenbu
Copy link
Contributor Author

On looking to that issue, I stumbled upon #8167. I do agree with the issue of relative / absolute uri transformation which is done even for a folder using another file system provider. Workspace file in VS Code keeps the URI as it is, where we can only have uris with the 'file:/' scheme in ours.

@msujew
Copy link
Member

msujew commented Feb 20, 2024

@rschnekenbu You don't need to implement this feature from scratch, see #13403. It should lay most of the groundwork for the this issue.

@rschnekenbu
Copy link
Contributor Author

Indeed, I was implementing similar parts. I rebased my work on your changes.
I can then also participate to your PR easily.

rschnekenbu added a commit to eclipsesource/theia that referenced this issue Feb 22, 2024
Also implements VS Code api for readOnly messages on FileSystemProvider

fixes eclipse-theia#13353

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Feb 22, 2024
Also implements VS Code api for readOnly messages on FileSystemProvider

fixes eclipse-theia#13353

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Feb 22, 2024
Also implements VS Code api for readOnly messages on FileSystemProvider

fixes eclipse-theia#13353

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Feb 28, 2024
Also implements VS Code api for readOnly messages on FileSystemProvider

fixes eclipse-theia#13353

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@msujew msujew linked a pull request Feb 28, 2024 that will close this issue
1 task
@msujew msujew closed this as completed in b96a84a Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants