Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] EnvironmentVariableMutator can now be configured #12941

Closed
Tracked by #12943
rschnekenbu opened this issue Sep 26, 2023 · 1 comment · Fixed by #12984
Closed
Tracked by #12943

[vscode] EnvironmentVariableMutator can now be configured #12941

rschnekenbu opened this issue Sep 26, 2023 · 1 comment · Fixed by #12984
Labels
vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

Vscode 1.82 has improved the support for EnvironmentVariableMutator, with options to configure when the Mutator is applied

See https://code.visualstudio.com/updates/v1_82#_configure-when-a-environmentvariablemutator-is-applied

EnvironmentVariable-Mutator

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Sep 26, 2023
@tsmaeder
Copy link
Contributor

tsmaeder commented Oct 9, 2023

Since we don't have shell integration, these options don't make much sense in the Theia case. The API documentation claims that the default value for both values is false, but looking at the case, that does not seem the case: in environmentVariableCollection.ts, the value of applyAtProcessCreation seems to default to true. My proposal would be to implement applyAtProcessCreation with a default of true and to mark applyAtShellIntegration as stubbed. In this way, the current behavior is preserved and we will still have an indication that we'll have to honor the shell integration flag if we ever decide to implement that feature.

tsmaeder added a commit to tsmaeder/theia that referenced this issue Oct 9, 2023
…12941

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder added a commit that referenced this issue Oct 19, 2023
Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants