Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information label "unrecognized key" is not localized in HotKey Binding #12878

Closed
Zebsterpasha opened this issue Aug 30, 2023 · 0 comments · Fixed by #12889
Closed

Information label "unrecognized key" is not localized in HotKey Binding #12878

Zebsterpasha opened this issue Aug 30, 2023 · 0 comments · Fixed by #12889
Labels
localization issues related to localization/internalization/nls

Comments

@Zebsterpasha
Copy link
Contributor

Zebsterpasha commented Aug 30, 2023 •
edited
Loading

Bug Description:

image

theia/packages/core/src/common/keys.ts

Line 291 in 5d7a655

throw new Error(`Unrecognized key '${keyString}' in '${keybinding}'`);

Additional Information

I will be able to fix this issue a little bit later by myself, if no one else fixes it soon :)

  • Operating System: any
  • Theia Version: the latest
@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label Aug 31, 2023
FernandoAscencio added a commit to FernandoAscencio/theia that referenced this issue Sep 1, 2023
@FernandoAscencio
Keybinding: Error Message Localization
c215fbe 
Closes eclipse-theia#12878

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
@FernandoAscencio FernandoAscencio mentioned this issue Sep 1, 2023
Merged
1 task
msujew pushed a commit that referenced this issue Sep 25, 2023
@FernandoAscencio @vince-fugnitto
Keybinding: Error Message Localization (#12889)
d2b7f3b 
Closes #12878

Signed-off-by: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keybinding: Error Message Localization FernandoAscencio/theia
2 participants
@vince-fugnitto @Zebsterpasha