Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[builtins] [proposed API] [vscode.git@1.72.2]: Theia lacks proposed API: editSessionIdentityProvider #12437

Closed
marcdumais-work opened this issue Apr 20, 2023 · 0 comments · Fixed by #12508
Closed

[builtins] [proposed API] [vscode.git@1.72.2]: Theia lacks proposed API: editSessionIdentityProvider #12437

marcdumais-work opened this issue Apr 20, 2023 · 0 comments · Fixed by #12508
Labels
builtins Issues related to VS Code builtin extensions git issues related to git vscode issues related to VSCode compatibility

Comments

@marcdumais-work
Copy link
Contributor

marcdumais-work commented Apr 20, 2023 •
edited
Loading

Bug Description:

n.workspace.registerEditSessionIdentityProvider is not a function

vscode.git 1.72.2 fails activating because it uses a new proposed API: API: Edit session identifier provider #157734

Since we do not currently have this proposed API, this extension is unusable - it fails at activation.

Full exception:

2023-04-20T19:09:33.928Z root ERROR [hosted-plugin: 600237] Activating extension 'Git (built-in)' failed: TypeError: n.workspace.registerEditSessionIdentityProvider is not a function
    at new t.GitEditSessionIdentityProvider (/tmp/vscode-unpacked/git-1.72.1.vsix/extension/dist/main.js:2:1084000)
    at R (/tmp/vscode-unpacked/git-1.72.1.vsix/extension/dist/main.js:2:1125963)
    at async I (/tmp/vscode-unpacked/git-1.72.1.vsix/extension/dist/main.js:2:1127747)
    at async t.activate (/tmp/vscode-unpacked/git-1.72.1.vsix/extension/dist/main.js:2:1128712)
    at async PluginManagerExtImpl.startPlugin (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:310:34)
    at async /home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:219:21
    at async PluginManagerExtImpl.$activatePlugin (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:271:13)
    at async Promise.all (index 0)
    at async PluginManagerExtImpl.activateBySingleEvent (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:266:9)
    at async PluginManagerExtImpl.$activateByEvent (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:250:13)

Steps to Reproduce:

git-1.72.1.zip

  1. use the attached extension in the example application. You may need to remove @theia/git and rebuild.
  2. confirm you see an exception at activation, similar to above
  3. Profit!

Additional Information

  • Operating System:
  • Theia Version:
@marcdumais-work marcdumais-work added vscode issues related to VSCode compatibility builtins Issues related to VS Code builtin extensions git issues related to git labels Apr 20, 2023
@marcdumais-work marcdumais-work changed the title [builtins] [proposed API] [vscode.git@1.72.2]: Theia misses proposed API: Edit session identifier provider [builtins] [proposed API] [vscode.git@1.72.2]: Theia lacks proposed API: editSessionIdentityProvider Apr 26, 2023
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
@marcdumais-work
[vscode] Stub implementation for proposed API: Edit session identity …
4644aa7 
…provider

This is a new proposed API, as of 1.72.2 it's only used in builtin
git (vscode.git).

Fixes eclipse-theia#12437

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
@marcdumais-work
[vscode] Stub for proposed API: EditSessionidentityProvider
eac2a3b 
This is a new proposed API, as of 1.72.2 it's only used in builtin
git (vscode.git).

Fixes eclipse-theia#12437

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
@marcdumais-work
[vscode] Stub for proposed API: EditSessionidentityProvider
4894063 
EditSessionidentityProvider is a new proposed API. As of 1.72.2
it's only used in built-in git (vscode.git).

This commit adds a stub implementation, sufficient to use
vscode.git 1.72.2 and hopefully later versions, if we need
it to. The eventual goal is to implement this API with a
working implementation.

Fixes eclipse-theia#12437

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
@marcdumais-work
[vscode] Stub for proposed API: EditSessionIdentityProvider
d8a40ae 
EditSessionIdentityProvider is a new proposed API. As of 1.72.2
it's only used in built-in git (vscode.git).

This commit adds a stub implementation, sufficient to use
vscode.git 1.72.2 and hopefully later versions, if we need
it to. The eventual goal is to implement this API with a
working implementation.

Fixes eclipse-theia#12437

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work marcdumais-work mentioned this issue May 9, 2023
Merged
1 task
marcdumais-work added a commit that referenced this issue May 10, 2023
@marcdumais-work @vince-fugnitto
[vscode] Stub for proposed API: EditSessionIdentityProvider (#12508)
fa94013 
* [vscode] Stub for proposed API: EditSessionIdentityProvider

EditSessionIdentityProvider is a new proposed API. As of 1.72.2
it's only used in built-in git (vscode.git).

This commit adds a stub implementation, sufficient to use
vscode.git 1.72.2 and hopefully later versions, if we need
it to. The eventual goal is to implement this API with a
working implementation.

Fixes #12437

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>

* Update packages/plugin-ext/src/plugin/workspace.ts

Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

---------

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue May 23, 2023
@marcdumais-work @vince-fugnitto @tsmaeder
[vscode] Stub for proposed API: EditSessionIdentityProvider (eclipse-…
10503eb 
…theia#12508)

* [vscode] Stub for proposed API: EditSessionIdentityProvider

EditSessionIdentityProvider is a new proposed API. As of 1.72.2
it's only used in built-in git (vscode.git).

This commit adds a stub implementation, sufficient to use
vscode.git 1.72.2 and hopefully later versions, if we need
it to. The eventual goal is to implement this API with a
working implementation.

Fixes eclipse-theia#12437

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>

* Update packages/plugin-ext/src/plugin/workspace.ts

Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

---------

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builtins Issues related to VS Code builtin extensions git issues related to git vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vscode] Stub for proposed API: EditSessionIdentityProvider marcdumais-work/theia
1 participant
@marcdumais-work