Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builtins] [proposed API] [vscode.markdown-language-features]: Theia misses proposed API: Document Paste #12430

Closed
marcdumais-work opened this issue Apr 18, 2023 · 0 comments · Fixed by #12512
Labels
builtins Issues related to VS Code builtin extensions markdown issues related to markdown vscode issues related to VSCode compatibility

Comments

@marcdumais-work
Copy link
Contributor

Bug Description:

Recent Markdown vscode builtin extension does not activate (see below). It looks like it's trying to use a proposed API that we do not support: "Document Paste": https://github.com/microsoft/vscode/blob/b25f6bf56c48d56fe59ae3fec641ed75c73a2980/src/vscode-dts/vscode.proposed.documentPaste.d.ts

I am currently encountering the issue testing pre-release vscode builtin extensions v1.72.2.

The example app pins this extension to a version that I think predates this API being used: 1.64.2

2023-04-18T16:02:13.527Z root ERROR [hosted-plugin: 220299] Activating extension 'Markdown Language Features (built-in)' failed: TypeError: i.languages.registerDocumentPasteEditProvider is not a function
    at t.registerPasteSupport (/tmp/vscode-unpacked/markdown-language-features-1.72.1.vsix/extension/dist/extension.js:1:1700637)
    at /tmp/vscode-unpacked/markdown-language-features-1.72.1.vsix/extension/dist/extension.js:1:1698626

Steps to Reproduce:

1.Replace the markdown-language-features extension with this pre-release one (v1.72.2):
markdown-language-features-1.72.1.zip
2. Start the example app (browser or Electron)
3. Look a the backlog log, confirm you see the exception from the Markdown extension, indicating failure of activation, like the one above

Additional Information

2023-04-18T16:02:13.341Z root INFO [hosted-plugin: 220299] PLUGIN_HOST(220299): PluginManagerExtImpl/loadPlugin(/tmp/vscode-unpacked/markdown-language-features-1.72.1.vsix/extension/dist/extension)
2023-04-18T16:02:13.527Z root ERROR [hosted-plugin: 220299] Activating extension 'Markdown Language Features (built-in)' failed: TypeError: i.languages.registerDocumentPasteEditProvider is not a function
    at t.registerPasteSupport (/tmp/vscode-unpacked/markdown-language-features-1.72.1.vsix/extension/dist/extension.js:1:1700637)
    at /tmp/vscode-unpacked/markdown-language-features-1.72.1.vsix/extension/dist/extension.js:1:1698626
    at t.activateShared (/tmp/vscode-unpacked/markdown-language-features-1.72.1.vsix/extension/dist/extension.js:1:1698668)
    at e.activate (/tmp/vscode-unpacked/markdown-language-features-1.72.1.vsix/extension/dist/extension.js:1:1755656)
    at async PluginManagerExtImpl.startPlugin (/home/<user>/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:308:34)
    at async /home/<user>/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:218:21
    at async PluginManagerExtImpl.$activatePlugin (/home/<user>/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:270:13)
    at async Promise.all (index 0)
    at async PluginManagerExtImpl.activateBySingleEvent (/home/<user>/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:265:9)
    at async PluginManagerExtImpl.$activateByEvent (/home/<user>/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:249:13)

  • Operating System:
  • Theia Version:
@marcdumais-work marcdumais-work added builtins Issues related to VS Code builtin extensions markdown issues related to markdown labels Apr 18, 2023
@marcdumais-work marcdumais-work changed the title [vscode.markdown-language-features][proposed API] languages.registerDocumentPasteEditProvider is not a function [builtins] [proposed API] [vscode.markdown-language-features]: Theia misses proposed API: Document Paste Apr 20, 2023
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
The immediate goal was for for the vscode built-in extension
`markdown-language-features` v1.72.2 (and a few prevgious I think),
to work again (minus the real "DocumentPaste" benefits.

Fixes eclipse-theia#12430

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
The immediate goal was for for the vscode built-in extension
`markdown-language-features` v1.72.2 (and a few prevgious I think),
to work again (minus the real "DocumentPaste" benefits.

Fixes eclipse-theia#12430

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
The immediate goal was for for the vscode built-in extension
`markdown-language-features` v1.72.2 (and a few prevgious I think),
to work again (minus the real "DocumentPaste" benefits.

Fixes eclipse-theia#12430

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
The immediate goal was for for the vscode built-in extension
`markdown-language-features` v1.72.2 (and a few prevgious I think),
to work again (minus the real "DocumentPaste" benefits.

Fixes eclipse-theia#12430

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
The immediate goal was for for the vscode built-in extension
`markdown-language-features` v1.72.2 (and a few prevgious I think),
to work again (minus the real "DocumentPaste" benefits.

Fixes eclipse-theia#12430

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 9, 2023
The immediate goal is for vscode built-in extension
`vscode.markdown-language-features` v1.72.2 to work again (minus
the "DocumentPaste" benefits.

Fixes eclipse-theia#12430

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit to marcdumais-work/theia that referenced this issue May 10, 2023
The immediate goal is for vscode built-in extension
`vscode.markdown-language-features` v1.72.2 to work again (minus
the "DocumentPaste" benefits.

Fixes eclipse-theia#12430

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work added a commit that referenced this issue May 10, 2023
The immediate goal is for vscode built-in extension
`vscode.markdown-language-features` v1.72.2 to work again (minus
the "DocumentPaste" benefits.

Fixes #12430

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work marcdumais-work added the vscode issues related to VSCode compatibility label May 11, 2023
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue May 23, 2023
The immediate goal is for vscode built-in extension
`vscode.markdown-language-features` v1.72.2 to work again (minus
the "DocumentPaste" benefits.

Fixes eclipse-theia#12430

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions markdown issues related to markdown vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant