Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Support CommentThread state property #12231

Closed
Tracked by #12233
rschnekenbu opened this issue Feb 27, 2023 · 0 comments · Fixed by #12454
Closed
Tracked by #12233

[vscode] Support CommentThread state property #12231

rschnekenbu opened this issue Feb 27, 2023 · 0 comments · Fixed by #12454
Assignees
@rschnekenbu
Labels
vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

rschnekenbu commented Feb 27, 2023 •
edited
Loading

see https://code.visualstudio.com/updates/v1_75#_comment-thread-state and microsoft/vscode#127473

Summary:
This API controls whether a comment renders as resolved or unresolved and can affect filtering in the Comments view.

CommentThreadState
@rschnekenbu rschnekenbu mentioned this issue Feb 27, 2023
Closed
3 tasks
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Mar 13, 2023
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Apr 19, 2023
@rschnekenbu
[vscode] support CommentThread state property
276b98a 
solves eclipse-theia#12231

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
This was referenced Apr 19, 2023
Closed
Open
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Apr 25, 2023
@rschnekenbu
[vscode] support CommentThread state property
7d085e2 
solves eclipse-theia#12231

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu mentioned this issue Apr 25, 2023
Merged
2 tasks
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Apr 25, 2023
@rschnekenbu
[vscode] support CommentThread state property
4dc048f 
solves eclipse-theia#12231

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
vince-fugnitto pushed a commit that referenced this issue Apr 26, 2023
@rschnekenbu
vscode: add support for CommentThread state property (#12454)
58be997 
Fixes #12231.

The commit adds support for the `CommentThread#state` VS Code API.
Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
2 participants
@rschnekenbu @vince-fugnitto