We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The download command is missing a localization when displaying progress regarding preparing the download:
theia/packages/filesystem/src/browser/download/file-download-service.ts
Lines 49 to 59 in ac7a9ff
We should properly localize the text as follows:
text
try { + const text = copyLink ? + nls.localize('theia/filesystem/prepareDownloadLink', 'Preparing download link...') : + nls.localize('theia/filesystem/prepareDownload', 'Preparing download...'); const [progress, result] = await Promise.all([ this.messageService.showProgress({ - text: `Preparing download${copyLink ? ' link' : ''}...`, options: { cancelable: true } + text, options: { cancelable: true } }, () => { cancel = true; }),
In addition, the default localization for the ProgressMessage.Cancel is missing:
ProgressMessage.Cancel
theia/packages/core/src/common/message-service-protocol.ts
Lines 54 to 55 in ac7a9ff
- export const Cancel = 'Cancel'; + export const Cancel = nls.localizeByDefault('Cancel');
Configure Display Language
explorer
node_modules
The text was updated successfully, but these errors were encountered:
Closed by #11988.
Sorry, something went wrong.
No branches or pull requests
Bug Description:
The download command is missing a localization when displaying progress regarding preparing the download:
theia/packages/filesystem/src/browser/download/file-download-service.ts
Lines 49 to 59 in ac7a9ff
We should properly localize the
text
as follows:In addition, the default localization for the
ProgressMessage.Cancel
is missing:theia/packages/core/src/common/message-service-protocol.ts
Lines 54 to 55 in ac7a9ff
Steps to Reproduce:
Configure Display Language
, install a new language-pack, and restart the applicationexplorer
node_modules
) by right-clicking the directory and choosing the "download" command (will be localized)Video
download-progress.mov
The text was updated successfully, but these errors were encountered: