Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playwright: tests fail on MacOS #10793

Closed
vince-fugnitto opened this issue Feb 24, 2022 · 1 comment · Fixed by #10826
Closed

playwright: tests fail on MacOS #10793

vince-fugnitto opened this issue Feb 24, 2022 · 1 comment · Fixed by #10826
Labels
bug bugs found in the application playwright issues related to playwright tests test issues related to unit and api tests

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The playwright tests (#10494) do not pass on macOS:

...
[playwright]   10 failed
...
[playwright]   10 skipped
[playwright]   28 passed (12m)
[playwright] yarn -s --cwd examples/playwright ui-tests-ci exited with code 1

I have not tested on windows, but since CI is only run on linux it is possible that it might also be problematic.

Steps to Reproduce:

  1. on macOS run:
    a. perform yarn
    b. perform yarn browser build
    c. perform yarn test:playwright
  2. confirm that the tests do not all pass, some are also skipped

Additional Info:
@vince-fugnitto vince-fugnitto added bug bugs found in the application test issues related to unit and api tests playwright issues related to playwright tests labels Feb 24, 2022
@paul-marechal paul-marechal mentioned this issue Feb 24, 2022
Closed
@paul-marechal paul-marechal changed the title playwright: tests fail on mac playwright: tests fail on MacOS Feb 24, 2022
ndoschek added a commit to eclipsesource/theia that referenced this issue Mar 2, 2022
@ndoschek
eclipse-theia#10793 Fix playwright tests for Windows and MacOS
4561e7a 
- Fix workspace path encoding for Windows
- Stabilize workspace path fetching
- Fix explorer review title button selectors
- Introduce OSUtil helper functions
- Fix shortcuts for MacOS

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10793
ndoschek added a commit to eclipsesource/theia that referenced this issue Mar 2, 2022
@ndoschek
eclipse-theia#10793 Fix playwright tests for Windows and MacOS
a1cae0e 
- Fix workspace path encoding for Windows
- Stabilize workspace path fetching
- Fix explorer review title button selectors
- Introduce OSUtil helper functions
- Fix shortcuts for MacOS
- Improve opening of TheiaViews (speeds up tests by approx. 10s)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10793
@ndoschek ndoschek mentioned this issue Mar 2, 2022
Merged
1 task
@ndoschek
Copy link
Contributor

ndoschek commented Mar 2, 2022 •
edited
Loading

Hi! I had a look at the playwright tests and fixed them for MacOS and Windows. They failed mainly due to path issues (Windows) and differing shortcuts (MacOS). See #10826

Also, tests are skipped if previous tests failed. With the fixes all tests should pass.

ndoschek added a commit to eclipsesource/theia that referenced this issue Mar 2, 2022
@ndoschek
eclipse-theia#10793 Fix playwright tests for Windows and MacOS
8e3b512 
- Fix workspace path encoding for Windows
- Stabilize workspace path fetching
- Fix explorer review title button selectors
- Introduce OSUtil helper functions
- Fix shortcuts for MacOS
- Improve opening of TheiaViews (speeds up tests by approx. 10s)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10793
ndoschek added a commit to eclipsesource/theia that referenced this issue Mar 16, 2022
@ndoschek
eclipse-theia#10793 Fix playwright tests for Windows and MacOS
a7572ff 
- Fix workspace path encoding for Windows
- Stabilize workspace path fetching
- Fix explorer review title button selectors
- Introduce OSUtil helper functions
- Fix shortcuts for MacOS
- Improve opening of TheiaViews (speeds up tests by approx. 10s)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10793
ndoschek added a commit to eclipsesource/theia that referenced this issue Mar 16, 2022
@ndoschek
eclipse-theia#10793 Fix playwright tests for Windows and MacOS
40a290d 
- Fix workspace path encoding for Windows
- Stabilize workspace path fetching
- Fix explorer review title button selectors
- Introduce OSUtil helper functions
- Fix shortcuts for MacOS
- Improve opening of TheiaViews (speeds up tests by approx. 10s)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10793
ndoschek added a commit to eclipsesource/theia that referenced this issue Mar 18, 2022
@ndoschek
eclipse-theia#10793 Fix playwright tests for Windows and MacOS
cb5f500 
- Fix workspace path encoding for Windows
- Stabilize workspace path fetching
- Fix explorer review title button selectors
- Introduce OSUtil helper functions
- Fix shortcuts for MacOS
- Improve opening of TheiaViews (speeds up tests by approx. 10s)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>

Fixes eclipse-theia#10793
@colin-grant-work colin-grant-work mentioned this issue Mar 18, 2022
Closed
7 tasks
colin-grant-work pushed a commit that referenced this issue Mar 18, 2022
@ndoschek
#10793 Fix playwright tests for Windows and MacOS (#10826)
b3a5aab 
- Fix workspace path encoding for Windows
- Stabilize workspace path fetching
- Fix explorer review title button selectors
- Introduce OSUtil helper functions
- Fix shortcuts for MacOS
- Improve opening of TheiaViews (speeds up tests by approx. 10s)

Contributed on behalf of STMicroelectronics

Signed-off-by: Nina Doschek <ndoschek@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application playwright issues related to playwright tests test issues related to unit and api tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#10793 Fix playwright tests for Windows and MacOS eclipsesource/theia
2 participants
@vince-fugnitto @ndoschek