Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal: remove deprecated activateTerminal method #10521

Closed
vince-fugnitto opened this issue Dec 8, 2021 · 0 comments · Fixed by #10529
Closed

terminal: remove deprecated activateTerminal method #10521

vince-fugnitto opened this issue Dec 8, 2021 · 0 comments · Fixed by #10529
Labels
beginners issues that are perfect for beginners good first issue good first issues for new contributors quality issues related to code and application quality terminal issues related to the terminal

Comments

@vince-fugnitto
Copy link
Member

Feature Description:

The activateTerminal method has been deprecated (~3 years) and should be removed from the codebase.
References to activateTerminal should be updated to instead use open.

/**
* Display new terminal widget.
* @param terminal - widget to attach.
* @deprecated use #open
*/
activateTerminal(terminal: TerminalWidget): void;

Fixes:

this.terminalService.activateTerminal(terminal);

- this.terminalService.activateTerminal(terminal); 
+ this.terminalService.open(terminal); 

- this.activateTerminal(termWidget); 
+ this.open(termWidget); 

activateTerminal(widget: TerminalWidget, widgetOptions?: ApplicationShell.WidgetOptions): void {
this.open(widget, { widgetOptions });
}

- activateTerminal(widget: TerminalWidget, widgetOptions?: ApplicationShell.WidgetOptions): void { 
-     this.open(widget, { widgetOptions }); 
- } 


@vince-fugnitto vince-fugnitto added beginners issues that are perfect for beginners terminal issues related to the terminal good first issue good first issues for new contributors quality issues related to code and application quality labels Dec 8, 2021
abhisharsinha pushed a commit to abhisharsinha/theia that referenced this issue Dec 9, 2021
abhisharsinha added a commit to abhisharsinha/theia that referenced this issue Dec 10, 2021
abhisharsinha added a commit to abhisharsinha/theia that referenced this issue Dec 10, 2021
abhisharsinha added a commit to abhisharsinha/theia that referenced this issue Dec 10, 2021
vince-fugnitto pushed a commit to abhisharsinha/theia that referenced this issue Dec 13, 2021
vince-fugnitto pushed a commit to abhisharsinha/theia that referenced this issue Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginners issues that are perfect for beginners good first issue good first issues for new contributors quality issues related to code and application quality terminal issues related to the terminal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant