Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output/terminal linkmatcher does not match windows-style-paths resulting in no clickable links. #10225

Closed
emilhammarstedtst opened this issue Oct 5, 2021 · 0 comments · Fixed by #10226
Labels
bug bugs found in the application OS/Windows issues related to the Windows OS terminal issues related to the terminal

Comments

@emilhammarstedtst
Copy link
Contributor

Bug Description:

When getting terminal output any windows-style-paths produced are not underlined when hovered or clickable due to TerminalLinkmatcherFiles-class passing string paths to Path-class that are not "valid".

not the same as issue #10224

Steps to Reproduce:

Run any terminal command that produces a file reference in output. eg. build error message from GCC
c:\code\my_test_prj\main.c:6:30: error: expected ';' before '}' token

The above output will not be hover-able and show as an underlined and be ctrl-clickable

Additional Information

  • Operating System: Windows
  • Theia Version: 1.18
@msujew msujew added bug bugs found in the application OS/Windows issues related to the Windows OS terminal issues related to the terminal labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application OS/Windows issues related to the Windows OS terminal issues related to the terminal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants