Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output/terminal Linkmatcher dont work with unix-style-paths in windows #10224

Open
emilhammarstedtst opened this issue Oct 5, 2021 · 2 comments
Open

Output/terminal Linkmatcher dont work with unix-style-paths in windows #10224

emilhammarstedtst opened this issue Oct 5, 2021 · 2 comments
Labels
bug bugs found in the application OS/Windows issues related to the Windows OS terminal issues related to the terminal

Comments

@emilhammarstedtst
Copy link
Contributor

Bug Description:

When using Git-Bash (possibly also cygwin/WSL etc. ) printed paths are not in standard windows style format.
this will result in failing to resolve path by FileService-class

Steps to Reproduce:

  1. open git bash as terminal
  2. run find $PWD
  3. show list of files will not be ctrl-clickable

Additional Information

  • Operating System: Windows
  • Theia Version: 1.18
@emilhammarstedtst emilhammarstedtst mentioned this issue Oct 5, 2021
Closed
@msujew msujew added OS/Windows issues related to the Windows OS terminal issues related to the terminal bug bugs found in the application labels Oct 5, 2021
@emilhammarstedtst emilhammarstedtst changed the title output/terminal Linkmatcher dont work with unix-style-paths in windows Output/terminal Linkmatcher dont work with unix-style-paths in windows Oct 5, 2021
@msujew
Copy link
Member

msujew commented Oct 8, 2021 •
edited
Loading

Hi @emilhammarstedtst, do you mind testing whether the issue still persists when using the changes made in #10244? Be aware that the current implementation only allows to click on files that exist in the workspace.

@emilhammarstedtst
Copy link
Contributor Author

Hi @emilhammarstedtst, do you mind testing whether the issue still persists when using the changes made in #10244? Be aware that the current implementation only allows to click on files that exist in the workspace.

Sorry to say it that it does not seem to solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application OS/Windows issues related to the Windows OS terminal issues related to the terminal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msujew @emilhammarstedtst