Improve language quick pick responsiveness (#12992)

eclipse-theia · Oct 12, 2023 · ff1ee2b · ff1ee2b
1 parent c625ba1
commit ff1ee2b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/packages/core/src/browser/i18n/language-quick-pick-service.ts b/packages/core/src/browser/i18n/language-quick-pick-service.ts
@@ -80,6 +80,7 @@ export class LanguageQuickPickService {
                 } else {
                     resolve(undefined);
                 }
+                quickInput.hide();
             });
             quickInput.onDidHide(() => {
                 resolve(undefined);

diff --git a/packages/vsx-registry/src/browser/vsx-language-quick-pick-service.ts b/packages/vsx-registry/src/browser/vsx-language-quick-pick-service.ts
@@ -22,6 +22,8 @@ import { PluginPackage, PluginServer } from '@theia/plugin-ext';
 import { OVSXClientProvider } from '../common/ovsx-client-provider';
 import { VSXSearchEntry } from '@theia/ovsx-client';
 import { VSCodeExtensionUri } from '@theia/plugin-ext-vscode/lib/common/plugin-vscode-uri';
+import { nls } from '@theia/core/lib/common/nls';
+import { MessageService } from '@theia/core/lib/common/message-service';
 
 @injectable()
 export class VSXLanguageQuickPickService extends LanguageQuickPickService {
@@ -35,6 +37,9 @@ export class VSXLanguageQuickPickService extends LanguageQuickPickService {
     @inject(PluginServer)
     protected readonly pluginServer: PluginServer;
 
+    @inject(MessageService)
+    protected readonly messageService: MessageService;
+
     protected override async getAvailableLanguages(): Promise<LanguageQuickPickItem[]> {
         const client = await this.clientProvider();
         const searchResult = await client.search({
@@ -62,8 +67,16 @@ export class VSXLanguageQuickPickService extends LanguageQuickPickService {
                     languages.set(localizationContribution.languageId, {
                         ...this.createLanguageQuickPickItem(localizationContribution),
                         execute: async () => {
-                            const extensionUri = VSCodeExtensionUri.toUri(extension.extension.name, extension.extension.namespace).toString();
-                            await this.pluginServer.deploy(extensionUri);
+                            const progress = await this.messageService.showProgress({
+                                text: nls.localizeByDefault('Installing {0} language support...',
+                                    localizationContribution.localizedLanguageName ?? localizationContribution.languageName ?? localizationContribution.languageId),
+                            });
+                            try {
+                                const extensionUri = VSCodeExtensionUri.toUri(extension.extension.name, extension.extension.namespace).toString();
+                                await this.pluginServer.deploy(extensionUri);
+                            } finally {
+                                progress.cancel();
+                            }
                         }
                     });
                 }