Support tasks presentation received from plugins

Support tasks presentation options received from plugins This expands the functionality introduced in pull request #6814 The following presentation options are now available for use by plugins: presentationOptions.reveal presentationOptions.focus presentationOptions.echo presentationOptions.showReuseMessage presentationOptions.panel presentationOptions.clear Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
eclipse-theia · Mar 24, 2021 · cb0d6e7 · cb0d6e7
1 parent eb83e0e
commit cb0d6e7
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 6 deletions.
diff --git a/packages/plugin-ext/src/common/plugin-api-rpc.ts b/packages/plugin-ext/src/common/plugin-api-rpc.ts
@@ -1319,10 +1319,19 @@ export interface TaskDto {
     problemMatcher?: any;
     group?: string;
     detail?: string;
+    presentation?: TaskPresentationOptionsDTO;
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     [key: string]: any;
 }
 
+export interface TaskPresentationOptionsDTO {
+    reveal?: number;
+    focus?: boolean;
+    echo?: boolean;
+    panel?: number;
+    showReuseMessage?: boolean;
+}
+
 export interface TaskExecutionDto {
     id: number;
     task: TaskDto;

diff --git a/packages/plugin-ext/src/plugin/type-converters.ts b/packages/plugin-ext/src/plugin/type-converters.ts
@@ -708,6 +708,9 @@ export function fromTask(task: theia.Task): TaskDto | undefined {
     const taskDto = {} as TaskDto;
     taskDto.label = task.name;
     taskDto.source = task.source;
+
+    taskDto.presentation = task.presentationOptions;
+
     if ((task as types.Task).hasProblemMatchers) {
         taskDto.problemMatcher = task.problemMatchers;
     }

diff --git a/packages/plugin-ext/src/plugin/types-impl.ts b/packages/plugin-ext/src/plugin/types-impl.ts
@@ -1774,6 +1774,7 @@ export class Task {
             this.hasTaskProblemMatchers = false;
         }
         this.isTaskBackground = false;
+        this.presentationOptions = Object.create(null);
     }
 
     get definition(): theia.TaskDefinition {

diff --git a/packages/task/src/common/task-protocol.ts b/packages/task/src/common/task-protocol.ts
@@ -28,15 +28,15 @@ export enum DependsOrder {
 }
 
 export enum RevealKind {
-    Always = 'always',
-    Silent = 'silent',
-    Never = 'never'
+    Always = 1,
+    Silent = 2,
+    Never = 3
 }
 
 export enum PanelKind {
-    Shared = 'shared',
-    Dedicated = 'dedicated',
-    New = 'new'
+    Shared = 1,
+    Dedicated = 2,
+    New = 3
 }
 
 export interface TaskOutputPresentation {