Skip to content

Commit

Permalink
ci: make plugin download sequential
Browse files Browse the repository at this point in the history
The commit updates our CI to run the `download:plugins` script
sequentially to improve rate limiting errors.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
  • Loading branch information
vince-fugnitto committed Nov 23, 2022
1 parent 5ffbef1 commit b58de21
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 6 deletions.
15 changes: 14 additions & 1 deletion .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,24 @@ jobs:
with:
python-version: '3.x'

- name: Install and Build
- name: Install
shell: bash
run: |
yarn --skip-integrity-check --network-timeout 100000
./scripts/check_git_status.sh
env:
NODE_OPTIONS: --max_old_space_size=4096
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9

- name: Download Plugins
if: runner.os == 'Linux'
shell: bash
run: |
yarn -s download:plugins
- name: Build
shell: bash
run: |
yarn build:examples
./scripts/check_git_status.sh
env:
Expand Down
2 changes: 1 addition & 1 deletion .gitpod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ ports:
- port: 9339 # Node.js debug port
onOpen: ignore
tasks:
- init: yarn --network-timeout 100000 && yarn build:examples
- init: yarn --network-timeout 100000 && yarn build:examples && yarn download:plugins
command: >
jwm &
yarn --cwd examples/browser start ../.. --hostname=0.0.0.0
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- [preferences] `PreferenceHeaderRendererContribution` moved to `preference-node-renderer-creator.ts`. [#11432](https://github.com/eclipse-theia/theia/pull/11432)
- [workspace] removed `workspace.supportMultiRootWorkspace` preference [#11538](https://github.com/eclipse-theia/theia/pull/11538)
- [workspace] removed method `isMultiRootWorkspaceEnabled` from `WorkspaceService` [#11538](https://github.com/eclipse-theia/theia/pull/11538)
- [repo] the `download:plugins` script resolves plugins sequentially by default [#11860](https://github.com/eclipse-theia/theia/pull/11860)

## v1.31.0 - 10/27/2022

Expand Down
2 changes: 1 addition & 1 deletion dev-packages/cli/src/download-plugins.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export default async function downloadPlugins(options: DownloadPluginsOptions =
ignoreErrors = false,
apiVersion = DEFAULT_SUPPORTED_API_VERSION,
apiUrl = 'https://open-vsx.org/api',
parallel = true,
parallel = false,
proxyUrl,
proxyAuthorization,
strictSsl
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/cli/src/theia.ts
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ async function theiaCli(): Promise<void> {
'parallel': {
describe: 'Download in parallel',
boolean: true,
default: true
default: false
},
'proxy-url': {
describe: 'Proxy URL'
Expand Down
2 changes: 1 addition & 1 deletion devfile.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ commands:
component: che-dev
command: >
killall node;
yarn && yarn build:examples
yarn && yarn download:plugins && yarn build:examples
workdir: /projects/theia
- name: >
theia: Launch Browser Backend
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"browser": "yarn -s --cwd examples/browser",
"build": "yarn -s compile && yarn -s build:examples",
"build-p": "yarn -s compile && lerna run --scope=\"@theia/example-*\" bundle --parallel",
"build:examples": "yarn -s download:plugins && lerna run --scope=\"@theia/example-*\" bundle --parallel",
"build:examples": "lerna run --scope=\"@theia/example-*\" bundle --parallel",
"clean": "yarn -s rebuild:clean && yarn -s lint:clean && node scripts/run-reverse-topo.js yarn -s clean",
"compile": "echo Compiling TypeScript sources... && yarn -s compile:clean && yarn -s compile:tsc",
"compile:clean": "ts-clean dev-packages/* packages/*",
Expand Down

0 comments on commit b58de21

Please sign in to comment.