Skip to content

Commit

Permalink
[languages] deprecated language contribution points
Browse files Browse the repository at this point in the history
Use VS Code extensions instead.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
  • Loading branch information
akosyakov committed Jun 30, 2020
1 parent f069ff7 commit b2856fd
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 2 deletions.
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,15 @@

Breaking Changes:

- <a name="1_4_0_replace_json">[json]</a> replaced `@theia/json` Theia extension with `vscode.json-language-features` VS Code extension [#7972](https://github.com/eclipse-theia/theia/pull/7972)
<a name="1_4_0_replace_json"></a>
- [[json]](#1_4_0_replace_json) replaced `@theia/json` Theia extension with `vscode.json-language-features` VS Code extension [#8112](https://github.com/eclipse-theia/theia/pull/8112)
- You can register JSON validations at application startup by implementing `JsonSchemaContribution` Theia contribution point.
- Alternatively you can provide JSON validations using VS Code [contributes.jsonValidation](https://code.visualstudio.com/api/references/contribution-points#contributes.jsonValidation) contribution point.
- <a name="1_4_0_absolute_user_storage_uri">[user-storage]</a> settings URI must be an absolute to satisfy expectations of `vscode.json-language-features` [#7972](https://github.com/eclipse-theia/theia/pull/7972)
<a name="1_4_0_absolute_user_storage_uri"></a>
- [[user-storage]](#1_4_0_absolute_user_storage_uri) settings URI must be an absolute to satisfy expectations of `vscode.json-language-features` [#8112](https://github.com/eclipse-theia/theia/pull/8112)
- If you imlpement a custom user storage make sure to check old relaitve locations, otherwise it can cause user data loss.
<a name="1_4_0_deprecate_languages"></a>
- [[languages]](#1_4_0_deprecate_languages) `@theia/languages` extension is deprecated, use VS Code extensions to provide language smartness [#8112](https://github.com/eclipse-theia/theia/pull/8112)

## v1.3.0

Expand Down
2 changes: 2 additions & 0 deletions packages/languages/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
> Deprecated since 1.4.0 - use VS Code extensions to contribute language smartness
<div align='center'>

<br />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ import { WorkspaceService } from '@theia/workspace/lib/browser';
import { InitializeParams } from 'monaco-languageclient';
import { Deferred } from '@theia/core/lib/common/promise-util';

/**
* @deprecated since 1.4.0 - use VS Code extensions to contribute language smartness
*/
export const LanguageClientContribution = Symbol('LanguageClientContribution');
export interface LanguageClientContribution extends LanguageContribution {
readonly running: boolean;
Expand All @@ -41,6 +44,9 @@ export interface LanguageClientContribution extends LanguageContribution {
restart(): void;
}

/**
* @deprecated since 1.4.0 - use VS Code extensions to contribute language smartness
*/
@injectable()
export abstract class BaseLanguageClientContribution implements LanguageClientContribution {

Expand Down
6 changes: 6 additions & 0 deletions packages/languages/src/node/language-server-contribution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,17 @@ export interface LanguageServerStartOptions {
parameters?: any
}

/**
* @deprecated since 1.4.0 - use VS Code extensions to contribute language smartness
*/
export const LanguageServerContribution = Symbol('LanguageServerContribution');
export interface LanguageServerContribution extends LanguageContribution {
start(clientConnection: IConnection, options: LanguageServerStartOptions): MaybePromise<void>;
}

/**
* @deprecated since 1.4.0 - use VS Code extensions to contribute language smartness
*/
@injectable()
export abstract class BaseLanguageServerContribution implements LanguageServerContribution {

Expand Down

0 comments on commit b2856fd

Please sign in to comment.