Merge branch 'master' into terminal-use-app-shell-methods

.github/workflows/playwright.yml

@@ -51,4 +51,4 @@ jobs:
       - name: Test (playwright)
         uses: GabrielBB/xvfb-action@v1
         with:
-          run: yarn test:playwright
+          run: yarn --cwd examples/playwright ui-tests-ci

.github/workflows/translation.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Use Python 3.x
         uses: actions/setup-python@v4
         with:
-          python-version: "3.x"
+          python-version: "3.11"
 
       - name: Install and Build
         shell: bash

CHANGELOG.md

@@ -4,15 +4,44 @@
 
 - [Previous Changelogs](https://github.com/eclipse-theia/theia/tree/master/doc/changelogs/)
 
-## v1.44.0
-- [vscode] added support for `autoClosingPairs` in the `LanguageConfiguration ` VS Code API [#13088](https://github.com/eclipse-theia/theia/pull/13088) - contributed on behalf of STMicroelectronics
-- [task] prevent task widget title from being changed by task process [#13003](https://github.com/eclipse-theia/theia/pull/13003)
-- [vscode] added Notebook CodeActionKind [#13093](https://github.com/eclipse-theia/theia/pull/13093) - contributed on behalf of STMicroelectronics
-- [vscode] added support for editor.indentSize API [#13105](https://github.com/eclipse-theia/theia/pull/13105) - contributed on behalf of STMicroelectronics
-- [vscode] added support to env.ondidChangeShell event [#13097](https://github.com/eclipse-theia/theia/pull/13097) - contributed on behalf of STMicroelectronics
-- [task] support `isDefault: false` in task group definition [#13075](https://github.com/eclipse-theia/theia/pull/13075) - contributed on behalf of STMicroelectronics
+## Unreleased
 - [terminal] Use application shell methods for expanding/collapsing bottom panel for "Terminal: Toggle Terminal" command [#13131](https://github.com/eclipse-theia/theia/pull/13131)
 
+## v1.44.0 - 11/30/2023
+
+- [application-manager] added option to copy `trash` dependency to the bundle [#13112](https://github.com/eclipse-theia/theia/pull/13112)
+- [application-package] bumped the default supported API from `1.82.0` to `1.83.1` [#13118](https://github.com/eclipse-theia/theia/pull/13118)
+- [ci] added smokes tests for production builds [#12965](https://github.com/eclipse-theia/theia/pull/12965)
+- [ci] updated CI to pin Python at `3.11` to resolve `node-gyp` errors [#13040](https://github.com/eclipse-theia/theia/pull/13040)
+- [core] added handling to prevent class name based contribution filtering [#13103](https://github.com/eclipse-theia/theia/pull/13103)
+- [core] added support for portable mode for electron apps [#12690](https://github.com/eclipse-theia/theia/pull/12690)
+- [core] fixed logic when handling listener events [#13079](https://github.com/eclipse-theia/theia/pull/13079)
+- [core] improved default translations using preferred keys [#13078](https://github.com/eclipse-theia/theia/pull/13078)
+- [core] updated `nls.metadata.json` for `1.83.1` [#13119](https://github.com/eclipse-theia/theia/pull/13119)
+- [core] updated proxy path handling for `socket.io` [#13054](https://github.com/eclipse-theia/theia/pull/13054)
+- [debug] fixed issue where the UI was not updated upon editing breakpoint conditions [#12980](https://github.com/eclipse-theia/theia/pull/12980)
+- [debug] fixed localizations of debug schema attributes [#13017](https://github.com/eclipse-theia/theia/pull/13017)
+- [debug] updated description field for thread stopped status [#13050](https://github.com/eclipse-theia/theia/pull/13050)
+- [documentation] added coding guidelines regarding `@stubbed` and `@monaco-uplift` tags [#13029](https://github.com/eclipse-theia/theia/pull/13029)
+- [documentation] updated broken link to `private-ext-scripts/README.md` [#13122](https://github.com/eclipse-theia/theia/pull/13122)
+- [filesystem] updated electron dialogs so they are modal by default [#13043](https://github.com/eclipse-theia/theia/pull/13043)
+- [notebook] fixed race condition for view registrations [#13115](https://github.com/eclipse-theia/theia/pull/13115)
+- [playwright] added basic support for electron [#12207](https://github.com/eclipse-theia/theia/pull/12207)
+- [plugin] added a command to list installed plugins [#12818](https://github.com/eclipse-theia/theia/pull/12818)
+- [plugin] added handling to forward webview log messages to the browser console [#13084](https://github.com/eclipse-theia/theia/pull/13084)
+- [plugin] added support for VS Code default language icons [#13014](https://github.com/eclipse-theia/theia/pull/13014)
+- [plugin] added support for `autoClosingPairs` in the `LanguageConfiguration` VS Code API [#13088](https://github.com/eclipse-theia/theia/pull/13088) - contributed on behalf of STMicroelectronics
+- [plugin] added support for the `CodeActionKind#Notebook` VS Code API [#13093](https://github.com/eclipse-theia/theia/pull/13093) - contributed on behalf of STMicroelectronics
+- [plugin] added support for the `TextEditorOptions.indentSize` VS Code API [#13105](https://github.com/eclipse-theia/theia/pull/13105) - contributed on behalf of STMicroelectronics
+- [plugin] added support for the `env.onDidChangeShell` VS Code API [#13097](https://github.com/eclipse-theia/theia/pull/13097) - contributed on behalf of STMicroelectronics
+- [private-ext-scripts] updated information regarding scripts [#13127](https://github.com/eclipse-theia/theia/pull/13127)
+- [repo] removed usages of `baseUrl` in `tsconfig` [#12981](https://github.com/eclipse-theia/theia/pull/12981)
+- [search-in-workspace] added support for search history hint in input fields [#12967](https://github.com/eclipse-theia/theia/pull/12967)
+- [search-in-workspace] fixed search-in-workspace line styling [#13071](https://github.com/eclipse-theia/theia/pull/13071)
+- [task] added handling to prevent the task widget title from being changed by task process [#13003](https://github.com/eclipse-theia/theia/pull/13003)
+- [task] added support for `isDefault: false` in task group definitions [#13075](https://github.com/eclipse-theia/theia/pull/13075) - contributed on behalf of STMicroelectronics
+- [toolbar] fixed rendering error for undefined toolbar groups [#13124](https://github.com/eclipse-theia/theia/pull/13124)
+
 ## v1.43.0 - 10/26/2023
 
 - [application-manager] fixed backend webpack output and watching [#12902](https://github.com/eclipse-theia/theia/pull/12902)

dev-packages/application-manager/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theia/application-manager",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia application manager API.",
   "publishConfig": {
     "access": "public"
@@ -33,9 +33,9 @@
     "@babel/plugin-transform-classes": "^7.10.0",
     "@babel/plugin-transform-runtime": "^7.10.0",
     "@babel/preset-env": "^7.10.0",
-    "@theia/application-package": "1.43.0",
-    "@theia/ffmpeg": "1.43.0",
-    "@theia/native-webpack-plugin": "1.43.0",
+    "@theia/application-package": "1.44.0",
+    "@theia/ffmpeg": "1.44.0",
+    "@theia/native-webpack-plugin": "1.44.0",
     "@types/fs-extra": "^4.0.2",
     "@types/semver": "^7.5.0",
     "babel-loader": "^8.2.2",
@@ -73,7 +73,7 @@
     }
   },
   "devDependencies": {
-    "@theia/ext-scripts": "1.43.0",
+    "@theia/ext-scripts": "1.44.0",
     "@types/node-abi": "*"
   },
   "nyc": {

dev-packages/application-manager/src/generator/webpack-generator.ts

@@ -393,6 +393,7 @@ if (process.platform !== 'win32') {
 
 const nativePlugin = new NativeWebpackPlugin({
     out: 'native',
+    trash: ${this.ifPackage('@theia/filesystem', 'true', 'false')},
     ripgrep: ${this.ifPackage(['@theia/search-in-workspace', '@theia/file-search'], 'true', 'false')},
     pty: ${this.ifPackage('@theia/process', 'true', 'false')},
     nativeBindings: {

dev-packages/application-package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theia/application-package",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia application package API.",
   "publishConfig": {
     "access": "public"
@@ -29,7 +29,7 @@
     "watch": "theiaext watch"
   },
   "dependencies": {
-    "@theia/request": "1.43.0",
+    "@theia/request": "1.44.0",
     "@types/fs-extra": "^4.0.2",
     "@types/semver": "^7.5.0",
     "@types/write-json-file": "^2.2.1",
@@ -42,7 +42,7 @@
     "write-json-file": "^2.2.0"
   },
   "devDependencies": {
-    "@theia/ext-scripts": "1.43.0"
+    "@theia/ext-scripts": "1.44.0"
   },
   "nyc": {
     "extends": "../../configs/nyc.json"

dev-packages/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theia/cli",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia CLI.",
   "publishConfig": {
     "access": "public"
@@ -30,12 +30,12 @@
     "clean": "theiaext clean"
   },
   "dependencies": {
-    "@theia/application-manager": "1.43.0",
-    "@theia/application-package": "1.43.0",
-    "@theia/ffmpeg": "1.43.0",
-    "@theia/localization-manager": "1.43.0",
-    "@theia/ovsx-client": "1.43.0",
-    "@theia/request": "1.43.0",
+    "@theia/application-manager": "1.44.0",
+    "@theia/application-package": "1.44.0",
+    "@theia/ffmpeg": "1.44.0",
+    "@theia/localization-manager": "1.44.0",
+    "@theia/ovsx-client": "1.44.0",
+    "@theia/request": "1.44.0",
     "@types/chai": "^4.2.7",
     "@types/mocha": "^10.0.0",
     "@types/node-fetch": "^2.5.7",

dev-packages/ffmpeg/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theia/ffmpeg",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia FFMPEG reader utility.",
   "publishConfig": {
     "access": "public"

dev-packages/localization-manager/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theia/localization-manager",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia localization manager API.",
   "publishConfig": {
     "access": "public"
@@ -39,7 +39,7 @@
     "typescript": "~4.5.5"
   },
   "devDependencies": {
-    "@theia/ext-scripts": "1.43.0"
+    "@theia/ext-scripts": "1.44.0"
   },
   "nyc": {
     "extends": "../../configs/nyc.json"

dev-packages/native-webpack-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theia/native-webpack-plugin",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Webpack Plugin for native dependencies of Theia.",
   "publishConfig": {
     "access": "public"

dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts

@@ -27,6 +27,7 @@ const REQUIRE_KEYMAPPING = './build/Release/keymapping';
 
 export interface NativeWebpackPluginOptions {
     out: string;
+    trash: boolean;
     ripgrep: boolean;
     pty: boolean;
     replacements?: Record<string, string>;
@@ -95,7 +96,9 @@ export class NativeWebpackPlugin {
             }
         );
         compiler.hooks.afterEmit.tapPromise(NativeWebpackPlugin.name, async () => {
-            await this.copyTrashHelper(compiler);
+            if (this.options.trash) {
+                await this.copyTrashHelper(compiler);
+            }
             if (this.options.ripgrep) {
                 await this.copyRipgrep(compiler);
             }

dev-packages/ovsx-client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theia/ovsx-client",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia Open-VSX Client",
   "publishConfig": {
     "access": "public"
@@ -29,7 +29,7 @@
     "watch": "theiaext watch"
   },
   "dependencies": {
-    "@theia/request": "1.43.0",
+    "@theia/request": "1.44.0",
     "semver": "^7.5.4"
   }
 }

dev-packages/private-eslint-plugin/package.json

@@ -1,16 +1,16 @@
 {
   "private": true,
   "name": "@theia/eslint-plugin",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Custom ESLint rules for developing Theia extensions and applications",
   "main": "index.js",
   "scripts": {
     "prepare": "tsc -b"
   },
   "dependencies": {
-    "@theia/core": "1.43.0",
-    "@theia/ext-scripts": "1.43.0",
-    "@theia/re-exports": "1.43.0",
+    "@theia/core": "1.44.0",
+    "@theia/ext-scripts": "1.44.0",
+    "@theia/re-exports": "1.44.0",
     "js-levenshtein": "^1.1.6"
   }
 }

dev-packages/private-ext-scripts/README.md

@@ -16,12 +16,12 @@
 `theiaext` is a command line tool to run shared npm scripts in Theia packages.\
 For instance, if you want add a new `hello` script that prints `Hello World`:
 
-- add a new script to [package.json](./package.json) with the `ext:` prefix.
+- add a new script to [./package.json](./package.json) with the `ext:` prefix.
 
 ```json
 {
     "name": "@theia/ext-scripts",
-    "scripts": {
+    "theia-monorepo-scripts": {
         "ext:hello": "echo 'Hello World'"
     }
 }

dev-packages/private-ext-scripts/package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "@theia/ext-scripts",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "license": "EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0",
   "description": "NPM scripts for Theia packages.",
   "bin": {

dev-packages/private-re-exports/package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "@theia/re-exports",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia re-export helper functions and scripts.",
   "main": "lib/index.js",
   "engines": {

dev-packages/request/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@theia/request",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia Proxy-Aware Request Service",
   "publishConfig": {
     "access": "public"

doc/Developing.md

@@ -165,7 +165,7 @@ Theia repository has multiple folders:
  - `packages` folder contains runtime packages, as the core package and extensions to it
  - `dev-packages` folder contains devtime packages
     - [@theia/cli](../dev-packages/cli/README.md) is a command line tool to manage Theia applications
-    - [@theia/ext-scripts](../dev-packages/ext-scripts/README.md) is a command line tool to share scripts between Theia runtime packages
+    - [@theia/ext-scripts](../dev-packages/private-ext-scripts/README.md) is a command line tool to share scripts between Theia runtime packages
  - `examples` folder contains example applications, both Electron-based and browser-based
  - `doc` folder provides documentation about how Theia works
  - `scripts` folder contains JavaScript scripts used by npm scripts when

doc/coding-guidelines.md

@@ -445,12 +445,11 @@ this.logger.info(``);
 console.info(``)
 ```
 > Why? All calls to console are intercepted on the frontend and backend and then forwarded to an `ILogger` instance already. The log level can be configured from the CLI: `theia start --log-level=debug`.
-> 
 
 ## "To Do" Tags
 There are situations where we can't properly implement some functionality at the time we merge a PR. In those cases, it is sometimes good practice to leave an indication that something needs to be fixed later in the code. This can be done by putting a "tag" string in a comment. This allows us to find the places we need to fix again later. Currently, we use two "standard" tags in Theia:
- * `@stubbed`  
-   This tag is used in VS Code API implementations. Sometimes we need an implementation of an API in order for VS Code extensions to start up correctly, but we can't provide a proper  implementation of the underlying feature at this time. This might be because a certain feature has no corresponding UI in Theia or becuase we do not have the resources to provide a proper implementation.  
+ * `@stubbed`
+   This tag is used in VS Code API implementations. Sometimes we need an implementation of an API in order for VS Code extensions to start up correctly, but we can't provide a proper  implementation of the underlying feature at this time. This might be because a certain feature has no corresponding UI in Theia or because we do not have the resources to provide a proper implementation.
 Using the `@stubbed` tag in a JSDoc comment will mark the element as "stubbed" on the [API status page](https://eclipse-theia.github.io/vscode-theia-comparator/status.html)
- * `@monaco-uplift`  
-   Use this tag when some functionality can be added or needs to be fixed when we move to a newer version of the monaco editor. If you know which minimum version of Monaco we need, you can add that as a reminder. 
+ * `@monaco-uplift`
+   Use this tag when some functionality can be added or needs to be fixed when we move to a newer version of the monaco editor. If you know which minimum version of Monaco we need, you can add that as a reminder.

examples/api-samples/package.json

@@ -1,21 +1,21 @@
 {
   "private": true,
   "name": "@theia/api-samples",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia - Example code to demonstrate Theia API",
   "dependencies": {
-    "@theia/core": "1.43.0",
-    "@theia/file-search": "1.43.0",
-    "@theia/filesystem": "1.43.0",
-    "@theia/monaco": "1.43.0",
+    "@theia/core": "1.44.0",
+    "@theia/file-search": "1.44.0",
+    "@theia/filesystem": "1.44.0",
+    "@theia/monaco": "1.44.0",
     "@theia/monaco-editor-core": "1.72.3",
-    "@theia/output": "1.43.0",
-    "@theia/ovsx-client": "1.43.0",
-    "@theia/search-in-workspace": "1.43.0",
-    "@theia/test": "1.43.0",
-    "@theia/toolbar": "1.43.0",
-    "@theia/vsx-registry": "1.43.0",
-    "@theia/workspace": "1.43.0"
+    "@theia/output": "1.44.0",
+    "@theia/ovsx-client": "1.44.0",
+    "@theia/search-in-workspace": "1.44.0",
+    "@theia/test": "1.44.0",
+    "@theia/toolbar": "1.44.0",
+    "@theia/vsx-registry": "1.44.0",
+    "@theia/workspace": "1.44.0"
   },
   "theiaExtensions": [
     {
@@ -54,6 +54,6 @@
     "clean": "theiaext clean"
   },
   "devDependencies": {
-    "@theia/ext-scripts": "1.43.0"
+    "@theia/ext-scripts": "1.44.0"
   }
 }

examples/api-tests/package.json

@@ -1,9 +1,9 @@
 {
   "name": "@theia/api-tests",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "description": "Theia API tests",
   "dependencies": {
-    "@theia/core": "1.43.0"
+    "@theia/core": "1.44.0"
   },
   "license": "EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0",
   "repository": {