change cell type when selecting markdown as a code cells language (#1…

…3933) Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
eclipse-theia · Jul 17, 2024 · 9e9a9f1 · 9e9a9f1
1 parent 7f928f2
commit 9e9a9f1
Showing 1 changed file with 16 additions and 9 deletions.
diff --git a/packages/notebook/src/browser/contributions/notebook-cell-actions-contribution.ts b/packages/notebook/src/browser/contributions/notebook-cell-actions-contribution.ts
@@ -365,15 +365,22 @@ export class NotebookCellActionContribution implements MenuContribution, Command
             execute: async (notebook?: NotebookModel, cell?: NotebookCellModel) => {
                 const selectedCell = cell ?? this.notebookEditorWidgetService.focusedEditor?.model?.selectedCell;
                 const activeNotebook = notebook ?? this.notebookEditorWidgetService.focusedEditor?.model;
-                if (selectedCell && activeNotebook) {
-                    const language = await this.languageQuickPickService.pickEditorLanguage(selectedCell.language);
-                    if (language?.value && language.value !== 'autoDetect') {
-                        this.notebookEditorWidgetService.focusedEditor?.model?.applyEdits([{
-                            editType: CellEditType.CellLanguage,
-                            index: activeNotebook.cells.indexOf(selectedCell),
-                            language: language.value.id
-                        }], true);
-                    }
+                if (!selectedCell || !activeNotebook) {
+                    return;
+                }
+                const language = await this.languageQuickPickService.pickEditorLanguage(selectedCell.language);
+                if (!language?.value || language.value === 'autoDetect') {
+                    return;
+                }
+                if (language.value.id === 'markdown') {
+                    selectedCell.language = 'markdown';
+                    changeCellType(activeNotebook, selectedCell, CellKind.Markup);
+                } else {
+                    this.notebookEditorWidgetService.focusedEditor?.model?.applyEdits([{
+                        editType: CellEditType.CellLanguage,
+                        index: activeNotebook.cells.indexOf(selectedCell),
+                        language: language.value.id
+                    }], true);
                 }
             }
         });