Skip to content

Commit

Permalink
Fix typings
Browse files Browse the repository at this point in the history
  • Loading branch information
tortmayr committed Mar 8, 2024
1 parent 96f5955 commit 958e541
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions packages/core/src/common/quick-pick-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ export interface QuickPick<T extends QuickPickItemOrSeparator> extends QuickInpu
matchOnDescription: boolean;
matchOnDetail: boolean;
keepScrollPosition: boolean;
buttons: ReadonlyArray<QuickInputButton>;
readonly onDidAccept: Event<{ inBackground: boolean } | undefined>;
readonly onDidChangeValue: Event<string>;
readonly onDidTriggerButton: Event<QuickInputButton>;
Expand Down
4 changes: 2 additions & 2 deletions packages/monaco/src/browser/monaco-quick-input-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -596,11 +596,11 @@ class MonacoQuickPick<T extends QuickPickItem> extends MonacoQuickInput implemen
});
}

get buttons(): ReadonlyArray<IQuickInputButton> {
get buttons(): ReadonlyArray<QuickInputButton> {
return this.wrapped.buttons;

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Playwright Tests (ubuntu-latest, Node.js 18.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Smoke Test for Browser Example Production Build on ubuntu-latest with Node.js 18.x

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Build and Test (windows-2019, node-16.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Build and Test (windows-2019, node-18.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Build and Test (windows-2019, node-20.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Build and Test (ubuntu-latest, node-16.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Build and Test (ubuntu-latest, node-18.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Build and Test (ubuntu-latest, node-20.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Build and Test (macos-11, node-16.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Lint

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Build and Test (macos-11, node-18.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.

Check failure on line 600 in packages/monaco/src/browser/monaco-quick-input-service.ts

View workflow job for this annotation

GitHub Actions / Build and Test (macos-11, node-20.x)

Type 'readonly IQuickInputButton[]' is not assignable to type 'readonly QuickInputButton[]'.
}

set buttons(buttons: ReadonlyArray<IQuickInputButton>) {
set buttons(buttons: ReadonlyArray<QuickInputButton>) {
this.wrapped.buttons = buttons;
}

Expand Down

0 comments on commit 958e541

Please sign in to comment.