don't render if no inspection available

Signed-off-by: Colin Grant <colin.grant@ericsson.com>
eclipse-theia · Apr 22, 2021 · 924115c · 924115c
1 parent 82c2bc4
commit 924115c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/preferences/src/browser/views/preference-editor-widget.tsx b/packages/preferences/src/browser/views/preference-editor-widget.tsx
@@ -185,8 +185,12 @@ export class PreferencesEditorWidget extends ReactWidget implements StatefulWidg
 
     protected renderSingleEntry(node: TreeNode): React.ReactNode {
         const values = this.preferenceValueRetrievalService.inspect<PreferenceItem>(node.id, this.model.currentScope.uri);
-        const preferenceNodeWithValueInAllScopes = { ...node, preference: { data: this.model.propertyList[node.id], values } };
-        return this.singlePreferenceFactory.render(preferenceNodeWithValueInAllScopes);
+        const data = this.model.propertyList[node.id];
+        if (data && values) {
+            const preferenceNodeWithValueInAllScopes = { ...node, preference: { data, values } };
+            return this.singlePreferenceFactory.render(preferenceNodeWithValueInAllScopes);
+        }
+        return undefined;
     }
 
     protected renderCategoryHeader({ node, visibleChildren }: PreferenceTreeNodeRow): React.ReactNode {