Skip to content

Commit

Permalink
[monaco] Fix bad preference initialization
Browse files Browse the repository at this point in the history
first register override identifier, because monaco will immediately
update already  opened documents and then initialize with
bad preferences.

Fixes #6449

Signed-off-by: Sven Efftinge <sven.efftinge@typefox.io>
  • Loading branch information
svenefftinge committed Oct 28, 2019
1 parent c9f3a63 commit 8814c20
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ export class MonacoFrontendApplicationContribution implements FrontendApplicatio
}
const registerLanguage = monaco.languages.register.bind(monaco.languages);
monaco.languages.register = language => {
registerLanguage(language);
// first register override identifier, because monaco will immediately update already opened documents and then initialize with bad preferences.
this.preferenceSchema.registerOverrideIdentifier(language.id);
registerLanguage(language);
};
}

Expand Down

0 comments on commit 8814c20

Please sign in to comment.