Fix "Converting circular structure to JSON" Error

eclipse-theia · May 11, 2019 · 50036a2 · 50036a2
1 parent dd9eb6b
commit 50036a2
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/packages/plugin-ext/src/api/rpc-protocol.ts b/packages/plugin-ext/src/api/rpc-protocol.ts
@@ -318,7 +318,8 @@ class MessageFactory {
         if (messageToSendHostId) {
             prefix = `"hostID":"${messageToSendHostId}",`;
         }
-        return `{${prefix}"type":${MessageType.Request},"id":"${req}","proxyId":"${rpcId}","method":"${method}","args":${JSON.stringify(args, ObjectsTransferrer.replacer)}}`;
+        return `{${prefix}"type":${MessageType.Request},"id":"${req}","proxyId":"${rpcId}","method":"${method}","args":
+        ${JSON.stringify(args, (key, value) => ObjectsTransferrer.replacer([], key, value))}}`;
     }
 
     public static replyOK(req: string, res: any, messageToSendHostId?: string): string {
@@ -329,7 +330,7 @@ class MessageFactory {
         if (typeof res === 'undefined') {
             return `{${prefix}"type":${MessageType.Reply},"id":"${req}"}`;
         }
-        return `{${prefix}"type":${MessageType.Reply},"id":"${req}","res":${JSON.stringify(res, ObjectsTransferrer.replacer)}}`;
+        return `{${prefix}"type":${MessageType.Reply},"id":"${req}","res":${JSON.stringify(res, (key, value) => ObjectsTransferrer.replacer([], key, value))}}`;
     }
 
     public static replyErr(req: string, err: any, messageToSendHostId?: string): string {
@@ -357,7 +358,7 @@ class MessageFactory {
 namespace ObjectsTransferrer {
 
     // tslint:disable-next-line:no-any
-    export function replacer(key: string | undefined, value: any): any {
+    export function replacer(cache: any[], key: string | undefined, value: any): any {
         if (value instanceof URI) {
             return {
                 $type: SerializedObjectType.THEIA_URI,
@@ -387,6 +388,15 @@ namespace ObjectsTransferrer {
                 $type: SerializedObjectType.VSCODE_URI,
                 data: uri.toString()
             } as SerializedObject;
+        } else if (value && typeof value === 'object') {
+            if (cache.indexOf(value) !== -1) {
+                try {
+                    return JSON.parse(JSON.stringify(value));
+                } catch (e) {
+                    return;
+                }
+            }
+            cache.push(value);
         }
 
         return value;