Support for declaring extensions as peer dependencies (#11808)

Ensures that the ExtensionPackageCollector also correctly picks up theia extensions that are declared as peerDependencies. Contributed on behalf of STMicroelectronics
eclipse-theia · Nov 28, 2022 · 2ec7d87 · 2ec7d87
1 parent c3ba8a9
commit 2ec7d87
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/dev-packages/application-package/src/extension-package-collector.ts b/dev-packages/application-package/src/extension-package-collector.ts
@@ -36,13 +36,11 @@ export class ExtensionPackageCollector {
     }
 
     protected collectPackages(pck: NodePackage): void {
-        if (!pck.dependencies) {
-            return;
-        }
-        // eslint-disable-next-line guard-for-in
-        for (const dependency in pck.dependencies) {
-            const versionRange = pck.dependencies[dependency]!;
-            this.collectPackage(dependency, versionRange);
+        for (const [dependency, versionRange] of [
+            ...Object.entries(pck.dependencies ?? {}),
+            ...Object.entries(pck.peerDependencies ?? {})
+        ]) {
+            this.collectPackage(dependency, versionRange!);
         }
     }
 

diff --git a/dev-packages/application-package/src/npm-registry.ts b/dev-packages/application-package/src/npm-registry.ts
@@ -47,6 +47,7 @@ export interface NodePackage {
     maintainers?: Maintainer[];
     keywords?: string[];
     dependencies?: Dependencies;
+    peerDependencies?: Dependencies;
     [property: string]: any;
 }