Prevent tabbing outside of dialog overlay (#14647)

Fixes #9894
eclipse-theia · Jan 8, 2025 · 11ea9e6 · 11ea9e6
1 parent 9edbf2c
commit 11ea9e6
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/packages/core/src/browser/dialogs.ts b/packages/core/src/browser/dialogs.ts
@@ -236,10 +236,17 @@ export abstract class AbstractDialog<T> extends BaseWidget {
             this.addAcceptAction(this.acceptButton, 'click');
         }
         this.addCloseAction(this.closeCrossNode, 'click');
+        this.toDisposeOnDetach.push(this.preventTabbingOutsideDialog());
         // TODO: use DI always to create dialog instances
         this.toDisposeOnDetach.push(DialogOverlayService.get().push(this));
     }
 
+    protected preventTabbingOutsideDialog(): Disposable {
+        const nonInertSiblings = Array.from(this.node.ownerDocument.body.children).filter(child => child !== this.node && !(child.hasAttribute('inert')));
+        nonInertSiblings.forEach(child => child.setAttribute('inert', ''));
+        return Disposable.create(() => nonInertSiblings.forEach(child => child.removeAttribute('inert')));
+    }
+
     protected handleEscape(event: KeyboardEvent): boolean | void {
         this.close();
     }