Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release page #308

Merged
merged 14 commits into from
Aug 11, 2022
Merged

Add release page #308

merged 14 commits into from
Aug 11, 2022

Conversation

JonasHelming
Copy link
Contributor

Signed-off-by: Jonas Helming jhelming@eclipsesource.com

@JonasHelming JonasHelming marked this pull request as draft July 18, 2022 21:35
@JonasHelming JonasHelming force-pushed the GH-307 branch 2 times, most recently from 1b02027 to 04d1844 Compare July 18, 2022 21:41
@JonasHelming JonasHelming force-pushed the GH-307 branch 13 times, most recently from 853617a to 4d1f74f Compare August 1, 2022 14:47
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasHelming are that many changes to the package-lock.json intentional?

23,691 additions, 27 deletions.


I see, the old package-lock.json was created with an outdated version of npm and a one-time update was necessary:

npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile

@JonasHelming
Copy link
Contributor Author

@JonasHelming are that many changes to the package-lock.json intentional?

23,691 additions, 27 deletions.

I see, the old package-lock.json was created with an outdated version of npm and a one-time update was necessary:

npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile

Yes, exactly, it needed an update since quite a while now

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably improve the styling, most notably for the "Compatible Technologies" section which seems to take up more space than the actual community release itself. Given new technologies will be added (upon request) we should probably exclude logos for the time being or altogether.

image

src/components/Releases.js Outdated Show resolved Hide resolved
src/components/Releases.js Outdated Show resolved Hide resolved
src/components/Releases.js Outdated Show resolved Hide resolved
src/components/Releases.js Outdated Show resolved Hide resolved
src/components/Releases.js Outdated Show resolved Hide resolved
JonasHelming and others added 7 commits August 9, 2022 22:56
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM.

I'm fine with the content, I just had some comments on minor details.

src/components/Releases.js Outdated Show resolved Hide resolved
src/components/Releases.js Outdated Show resolved Hide resolved
JonasHelming and others added 2 commits August 11, 2022 16:14
Co-authored-by: Paul Maréchal <paul.marechal@ericsson.com>
Co-authored-by: Paul Maréchal <paul.marechal@ericsson.com>
@JonasHelming JonasHelming merged commit 8e8a3c9 into master Aug 11, 2022
@vince-fugnitto vince-fugnitto deleted the GH-307 branch August 11, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants