Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add github actions workflow #133

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

vince-fugnitto
Copy link
Member

What it does

The commit includes a github actions workflow for the project (in addition to the already existing jenkins build). The workflow will
hopefully help contributors identify issues in prs and cron job sooner.

How to test

The CI should pass:

  • build
  • lint

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit includes a `github actions` workflow for the project (in
addition to the already existing jenkins build). The workflow will
hopefully help contributors identify issues in prs and cron job sooner.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the ci issues related to ci - build, linting label Aug 2, 2021
@vince-fugnitto vince-fugnitto self-assigned this Aug 2, 2021
@marcdumais-work
Copy link
Contributor

I think this will also help whenever we have issues with Jenkins, like it's the case now, and will be in a couple of weeks when it's down for maintenance. We can then at least hope to have some confidence that we can merge without breaking everything :)

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcdumais-work
Copy link
Contributor

We can add tests when we have a browser version of Blueprint (*), to run them on.

(*) it's being worked-on: #74

@vince-fugnitto vince-fugnitto merged commit 4d8f470 into eclipse-theia:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to ci - build, linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants