Skip to content

Commit

Permalink
[built-ins] Update bundled extensions
Browse files Browse the repository at this point in the history 
Since Theia recently has caught-up to vscode 1.77.0,  we are now able
to use the latest version of pretty much every extension, in Blueprint.

Doing so means a massive update, version-wise, of the vscode builtins and
Java extensions that we bundle. So, it might bring some little issues.
But it will also bring big benefits.

I have removed all pinned version of built-ins, because I beleive we can
successfully run the latest of everything.

I have also replaced individual Java extensions with a pack, which
dependends on the few most popular Java extensions. One of them,
I beleive, is proprietary: `Visual Studio IntelliCode`. I've added
it to the "exclude list". In anycase, this extension is not available
on the public open-vsx registry and so can't be fetched by mistake,
e.g. if the exclusion for it were removed by accident.

Done like this, it should be more future-proof: we will pick the latest
compatible version of each bundled extension, each time we build. If
we encounter punctual problems in the future with later versions of the
extensions we bundle, we can use strategic temporary pinning, to
maintain functionality while fixing the issue.

[build] Make the Theia plugin download script go at it sequentially

I've had the plugins download fail on occasion locally, over
"redhat.java". I suspect a race condition, when using the default
mode where multiple plugins are downloaded at the same time.

[Theia] add `@theia/secondary-window`

I've added this extension to the browser version of Blueprint. We
can add it to the Electron version of Blueprint once it's available
in a release.

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
  • Loading branch information
@marcdumais-work @jfaltermeier
marcdumais-work authored and jfaltermeier committed Jun 7, 2023
1 parent 490367b commit 410a519
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 23 deletions.
20 changes: 9 additions & 11 deletions applications/browser/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
"warnOnPotentiallyInsecureHostPattern": false,
"preferences": {
"toolbar.showToolbar": true,
"files.enableTrash": false
"files.enableTrash": false,
"security.workspace.trust.enabled": false
}
}
},
Expand Down Expand Up @@ -56,8 +57,8 @@
"@theia/getting-started": "1.38.0",
"@theia/keymaps": "1.38.0",
"@theia/markers": "1.38.0",
"@theia/messages": "1.38.0",
"@theia/memory-inspector": "1.38.0",
"@theia/messages": "1.38.0",
"@theia/metrics": "1.38.0",
"@theia/mini-browser": "1.38.0",
"@theia/monaco": "1.38.0",
Expand All @@ -73,6 +74,7 @@
"@theia/scm": "1.38.0",
"@theia/scm-extra": "1.38.0",
"@theia/search-in-workspace": "1.38.0",
"@theia/secondary-window": "1.38.0",
"@theia/task": "1.38.0",
"@theia/terminal": "1.38.0",
"@theia/timeline": "1.38.0",
Expand Down Expand Up @@ -102,21 +104,17 @@
},
"theiaPluginsDir": "plugins",
"theiaPlugins": {
"vscode.markdown-language-features": "https://open-vsx.org/api/vscode/markdown-language-features/1.39.2/file/vscode.markdown-language-features-1.39.2.vsix",
"vscode-builtin-extensions-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.50.1/file/eclipse-theia.builtin-extension-pack-1.50.1.vsix",
"vscode.typescript": "https://open-vsx.org/api/vscode/typescript/1.62.3/file/vscode.typescript-1.62.3.vsix",
"vscode.typescript-language-features": "https://open-vsx.org/api/vscode/typescript-language-features/1.62.3/file/vscode.typescript-language-features-1.62.3.vsix",
"redhat.java": "https://open-vsx.org/api/redhat/java/0.73.0/file/redhat.java-0.73.0.vsix",
"vscjava.vscode-java-debug": "https://open-vsx.org/api/vscjava/vscode-java-debug/0.30.0/file/vscjava.vscode-java-debug-0.30.0.vsix",
"vscjava.vscode-java-test": "https://open-vsx.org/api/vscjava/vscode-java-test/0.26.1/file/vscjava.vscode-java-test-0.26.1.vsix",
"vscjava.vscode-maven": "https://open-vsx.org/api/vscjava/vscode-maven/0.21.2/file/vscjava.vscode-maven-0.21.2.vsix",
"vscjava.vscode-java-dependency": "https://open-vsx.org/api/vscjava/vscode-java-dependency/0.16.0/file/vscjava.vscode-java-dependency-0.16.0.vsix"
"vscode-builtin-extensions-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.77.0/file/eclipse-theia.builtin-extension-pack-1.77.0.vsix",
"vscjava.vscode-java-pack": "https://open-vsx.org/api/vscjava/vscode-java-pack/0.25.11/file/vscjava.vscode-java-pack-0.25.11.vsix"
},
"theiaPluginsExcludeIds": [
"ms-vscode.js-debug-companion",
"VisualStudioExptTeam.vscodeintellicode",
"vscode.builtin-notebook-renderers",
"vscode.extension-editing",
"vscode.github",
"vscode.github-authentication",
"vscode.ipynb",
"vscode.microsoft-authentication"
]
}
21 changes: 9 additions & 12 deletions applications/electron/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
"config": {
"applicationName": "Theia Blueprint",
"preferences": {
"toolbar.showToolbar": true
"toolbar.showToolbar": true,
"security.workspace.trust.enabled": false
}
}
},
Expand Down Expand Up @@ -56,8 +57,8 @@
"@theia/getting-started": "1.38.0",
"@theia/keymaps": "1.38.0",
"@theia/markers": "1.38.0",
"@theia/messages": "1.38.0",
"@theia/memory-inspector": "1.38.0",
"@theia/messages": "1.38.0",
"@theia/metrics": "1.38.0",
"@theia/mini-browser": "1.38.0",
"@theia/monaco": "1.38.0",
Expand Down Expand Up @@ -126,26 +127,22 @@
"update:checksum": "ts-node scripts/update-checksum.ts",
"update:blockmap": "ts-node scripts/update-blockmap.ts",
"update:next": "ts-node ../../scripts/update-theia-to-next.ts",
"download:plugins": "theia download:plugins --rate-limit=15",
"download:plugins": "theia download:plugins --rate-limit=15 --parallel=false",
"test": "mocha --timeout 60000 \"./test/*.spec.js\""
},
"theiaPluginsDir": "plugins",
"theiaPlugins": {
"vscode.markdown-language-features": "https://open-vsx.org/api/vscode/markdown-language-features/1.39.2/file/vscode.markdown-language-features-1.39.2.vsix",
"vscode-builtin-extensions-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.50.1/file/eclipse-theia.builtin-extension-pack-1.50.1.vsix",
"vscode.typescript": "https://open-vsx.org/api/vscode/typescript/1.62.3/file/vscode.typescript-1.62.3.vsix",
"vscode.typescript-language-features": "https://open-vsx.org/api/vscode/typescript-language-features/1.62.3/file/vscode.typescript-language-features-1.62.3.vsix",
"redhat.java": "https://open-vsx.org/api/redhat/java/0.73.0/file/redhat.java-0.73.0.vsix",
"vscjava.vscode-java-debug": "https://open-vsx.org/api/vscjava/vscode-java-debug/0.30.0/file/vscjava.vscode-java-debug-0.30.0.vsix",
"vscjava.vscode-java-test": "https://open-vsx.org/api/vscjava/vscode-java-test/0.26.1/file/vscjava.vscode-java-test-0.26.1.vsix",
"vscjava.vscode-maven": "https://open-vsx.org/api/vscjava/vscode-maven/0.21.2/file/vscjava.vscode-maven-0.21.2.vsix",
"vscjava.vscode-java-dependency": "https://open-vsx.org/api/vscjava/vscode-java-dependency/0.16.0/file/vscjava.vscode-java-dependency-0.16.0.vsix"
"vscode-builtin-extensions-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.77.0/file/eclipse-theia.builtin-extension-pack-1.77.0.vsix",
"vscjava.vscode-java-pack": "https://open-vsx.org/api/vscjava/vscode-java-pack/0.25.11/file/vscjava.vscode-java-pack-0.25.11.vsix"
},
"theiaPluginsExcludeIds": [
"ms-vscode.js-debug-companion",
"VisualStudioExptTeam.vscodeintellicode",
"vscode.builtin-notebook-renderers",
"vscode.extension-editing",
"vscode.github",
"vscode.github-authentication",
"vscode.ipynb",
"vscode.microsoft-authentication"
]
}
7 changes: 7 additions & 0 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2515,6 +2515,13 @@
"@vscode/ripgrep" "^1.14.2"
minimatch "^5.1.0"

"@theia/secondary-window@1.38.0":
version "1.38.0"
resolved "https://registry.yarnpkg.com/@theia/secondary-window/-/secondary-window-1.38.0.tgz#78699f18d290235e24240a10850b73f9f582ebbf"
integrity sha512-jQ0aPKqRsrmYIDA1HwOkNWv+guGk97WnHpMcGvZnc4d4TZGCaR9/6nDhQwgeJDQUFiNOFtCGr4eclK+Si0JDnA==
dependencies:
"@theia/core" "1.38.0"

"@theia/task@1.38.0":
version "1.38.0"
resolved "https://registry.yarnpkg.com/@theia/task/-/task-1.38.0.tgz#908305e25c718b082fc4836405d53e5f42f0a885"
Expand Down

0 comments on commit 410a519

Please sign in to comment.