Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated electron-app does not work anymore #166

Closed
jfaltermeier opened this issue May 3, 2023 · 0 comments · Fixed by #167
Closed

Generated electron-app does not work anymore #166

jfaltermeier opened this issue May 3, 2023 · 0 comments · Fixed by #167
Assignees

Comments

@jfaltermeier
Copy link
Contributor

Currently generating the hello-world app has multiple problems.

The first issue is

'src/browser/hello-world-contribution.ts(14,10): error TS1239: Unable to resolve signature of parameter decorator when called as an expression.\r\n' +
    "  Argument of type 'undefined' is not assignable to parameter of type 'string'.\r\n" +

As far as I can see this is fixed on master already (#164) but not released yet.

Testing the generation with a local build gives this error then:

electron-app: > electron-app@0.0.0 prepare
electron-app: > theia build --mode development
electron-app: Updated dependencies, please run "install" again
electron-app: npm ERR! Lifecycle script `prepare` failed with error: 
electron-app: npm ERR! Error: command failed 
electron-app: npm ERR!   in workspace: electron-app@0.0.0 
electron-app: npm ERR!   at location: /tmp/my-extension/electron-app 
lerna ERR! execute callback with error
lerna ERR! Error: Command failed: npm run prepare
lerna ERR! Updated dependencies, please run "install" again
lerna ERR! npm ERR! Lifecycle script `prepare` failed with error: 
lerna ERR! npm ERR! Error: command failed 
lerna ERR! npm ERR!   in workspace: electron-app@0.0.0 
lerna ERR! npm ERR!   at location: /tmp/my-extension/electron-app 
lerna ERR! 
lerna ERR! 
lerna ERR! > electron-app@0.0.0 prepare
lerna ERR! > theia build --mode development
lerna ERR! 
lerna ERR! 
lerna ERR!     at /tmp/my-extension/node_modules/execa/index.js:236:11
lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately.
@jfaltermeier jfaltermeier self-assigned this May 3, 2023
jfaltermeier added a commit that referenced this issue May 3, 2023
jfaltermeier added a commit that referenced this issue May 3, 2023
* Remove electron version
* If electron is set in options, run yarn once upfront (this will let
theia edit the package.json with the currently supported electron
version)
* run yarn (a second time) as before
jfaltermeier added a commit that referenced this issue May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant