Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[538] Add actions in PartUsage and PartDefinition #539

Merged
merged 2 commits into from
Jul 16, 2024
Merged

[538] Add actions in PartUsage and PartDefinition #539

merged 2 commits into from
Jul 16, 2024

Conversation

gdaniel
Copy link
Contributor

@gdaniel gdaniel commented Jul 12, 2024

Bug: #538

@AxelRICHARD AxelRICHARD added this to the 2024.9.0 milestone Jul 12, 2024
@AxelRICHARD AxelRICHARD linked an issue Jul 12, 2024 that may be closed by this pull request
Add actions in PartUsage and PartDefinition #538
Closed
@gdaniel
Copy link
Contributor Author

gdaniel commented Jul 13, 2024

I am not sure the containment links work as expected with Actions:
image

I am wondering if:

  1. We want to have the links for Actions on the diagram (like between PartDefinition and its Action)
    I guess we do, we have the class for it (UsageNestedActionUsageEdgeDescriptionProvider) but it is not used in GeneralViewDiagramDescriptionProvider.
  2. We want to have the links for Actions inside the Action Flow compartment
    I assume we don't, in this case I can update the PR to rework these edges.

@gdaniel
Copy link
Contributor Author

gdaniel commented Jul 15, 2024

Done, there may be some work to do on the ActionFlow view to replicate this behavior.

@gdaniel gdaniel force-pushed the gda/enh/actionInPart branch 3 times, most recently from 2ecf87e to 06ce00a Compare July 15, 2024 16:45
@gdaniel @AxelRICHARD
[538] Add actions in PartUsage and PartDefinition
6d97ed4 
Bug: eclipse-syson#538
Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>
@gdaniel @AxelRICHARD
[538] Fix ownedAction/nestedAction edge in ActionFlow View
04ddff2 
This commit ensures that the edge is visible if the owned/nested action
is represented outside of its container.

Bug: eclipse-syson#538
Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>
@AxelRICHARD AxelRICHARD merged commit 646500f into eclipse-syson:main Jul 16, 2024
3 checks passed
@gdaniel gdaniel deleted the gda/enh/actionInPart branch July 18, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxelRICHARD AxelRICHARD AxelRICHARD approved these changes

Assignees
No one assigned
Labels
pr: to review soon priority: low
Projects
None yet
Milestone
2024.9.0
Development

Successfully merging this pull request may close these issues.

Add actions in PartUsage and PartDefinition
2 participants
@gdaniel @AxelRICHARD