Support parsing nested JSON properties and schema check for nested properties #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
linyguo
commented
Aug 13, 2024
linyguo
commented
- Add a function to support parsing nested properties
- Update test scenarios for nested properties and schema check
RemindD
reviewed
Aug 13, 2024
lirenjie95
reviewed
Aug 14, 2024
Signed-off-by: linyguo <lingyunguo@microsoft.com>
Haishi2016
reviewed
Aug 23, 2024
api/pkg/apis/v1alpha1/providers/config/catalog/catalogprovider_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: linyguo <lingyunguo@microsoft.com>
Signed-off-by: linyguo <lingyunguo@microsoft.com>
Haishi2016
reviewed
Sep 3, 2024
iwangjintian
approved these changes
Sep 6, 2024
msftcoderdjw
previously approved these changes
Sep 9, 2024
Haishi2016
reviewed
Sep 9, 2024
msftcoderdjw
approved these changes
Sep 10, 2024
|
Fixed #210 |
LeiQL
pushed a commit
to LeiQL/symphony
that referenced
this pull request
Sep 19, 2024
…operties (eclipse-symphony#398) * support nested json properties * update go mod for coa * update scenario 04 * update go.sum * go mod tidy * update ut and syntax * update schema doc * fix test case * update samples * add doc for gojq * revert file Signed-off-by: linyguo <lingyunguo@microsoft.com> * revert file Signed-off-by: linyguo <lingyunguo@microsoft.com> * revert symphony-ghcr-values.yaml * merge update unit test * resolve go mod * update gojq format string * revert sample changes * update * update config expression check and docs --------- Signed-off-by: linyguo <lingyunguo@microsoft.com> Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com>
msftcoderdjw
added a commit
that referenced
this pull request
Sep 19, 2024
* target logs * fix iot test * logging * Add trace value in unwinding parent catalogs (#454) * add traceValue when read catalog property in parent catalog * update trace value * Turn off validation in standalone mode for cross type check (#446) * Turn off standalone validation for cross type check * Handle state.Spec is nil --------- Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * add parent circular dependency check in catalog validation (#453) * add parent circular dependency validation * update manifest name * update helper function --------- Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * Block campaign update and delete with running activation (#458) * update actions/upload-artifact version from v2 to v4 (#461) * Support parsing nested JSON properties and schema check for nested properties (#398) * support nested json properties * update go mod for coa * update scenario 04 * update go.sum * go mod tidy * update ut and syntax * update schema doc * fix test case * update samples * add doc for gojq * revert file Signed-off-by: linyguo <lingyunguo@microsoft.com> * revert file Signed-off-by: linyguo <lingyunguo@microsoft.com> * revert symphony-ghcr-values.yaml * merge update unit test * resolve go mod * update gojq format string * revert sample changes * update * update config expression check and docs --------- Signed-off-by: linyguo <lingyunguo@microsoft.com> Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * update canary sample for minikube (#462) * Log lines improvement for workflow and solution deployment and small refactors (#447) * Log lines improvement and small refactors * return status when nextStage is not empty * Check pause status when selfDriving is false. Fix typo * Check pauseRequested regardless of selfDriving or not --------- Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * fixed broken markdown links (#471) * use () to convert expression output to string (#470) * add context in evaluation context (#459) * add context in evaluation context * update context in stage manager --------- Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * checking if the activation still exist for waitcount = 0 or waitcount very large. (#460) Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * fix helm test --------- Signed-off-by: linyguo <lingyunguo@microsoft.com> Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> Co-authored-by: linyguo <lingyunguo@microsoft.com> Co-authored-by: Xingdong Li <xdlisjtu@gmail.com> Co-authored-by: Renjie Li <renjieli@microsoft.com> Co-authored-by: Haishi2016 <hbai@microsoft.com>
yanjiaxin534
pushed a commit
to yanjiaxin534/symphony
that referenced
this pull request
Nov 19, 2024
* target logs * fix iot test * logging * Add trace value in unwinding parent catalogs (eclipse-symphony#454) * add traceValue when read catalog property in parent catalog * update trace value * Turn off validation in standalone mode for cross type check (eclipse-symphony#446) * Turn off standalone validation for cross type check * Handle state.Spec is nil --------- Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * add parent circular dependency check in catalog validation (eclipse-symphony#453) * add parent circular dependency validation * update manifest name * update helper function --------- Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * Block campaign update and delete with running activation (eclipse-symphony#458) * update actions/upload-artifact version from v2 to v4 (eclipse-symphony#461) * Support parsing nested JSON properties and schema check for nested properties (eclipse-symphony#398) * support nested json properties * update go mod for coa * update scenario 04 * update go.sum * go mod tidy * update ut and syntax * update schema doc * fix test case * update samples * add doc for gojq * revert file Signed-off-by: linyguo <lingyunguo@microsoft.com> * revert file Signed-off-by: linyguo <lingyunguo@microsoft.com> * revert symphony-ghcr-values.yaml * merge update unit test * resolve go mod * update gojq format string * revert sample changes * update * update config expression check and docs --------- Signed-off-by: linyguo <lingyunguo@microsoft.com> Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * update canary sample for minikube (eclipse-symphony#462) * Log lines improvement for workflow and solution deployment and small refactors (eclipse-symphony#447) * Log lines improvement and small refactors * return status when nextStage is not empty * Check pause status when selfDriving is false. Fix typo * Check pauseRequested regardless of selfDriving or not --------- Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * fixed broken markdown links (eclipse-symphony#471) * use () to convert expression output to string (eclipse-symphony#470) * add context in evaluation context (eclipse-symphony#459) * add context in evaluation context * update context in stage manager --------- Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * checking if the activation still exist for waitcount = 0 or waitcount very large. (eclipse-symphony#460) Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> * fix helm test --------- Signed-off-by: linyguo <lingyunguo@microsoft.com> Co-authored-by: Jiawei Du <59427055+msftcoderdjw@users.noreply.github.com> Co-authored-by: linyguo <lingyunguo@microsoft.com> Co-authored-by: Xingdong Li <xdlisjtu@gmail.com> Co-authored-by: Renjie Li <renjieli@microsoft.com> Co-authored-by: Haishi2016 <hbai@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.