Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Memory String Lock provider #388

Merged

Conversation

FireDefend
Copy link
Contributor

@FireDefend FireDefend commented Aug 6, 2024

Add Key Lock interface
Add Memory Key Lock implementation

User can acquire lock at unique string level

Copy link
Contributor

@RemindD RemindD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mis click the approve previously. Please see my below comments.

coa/pkg/apis/v1alpha2/providers/stringlock/stringlock.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Haishi2016 Haishi2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memorystringlock.go should be memory.go under stringlock/memory folder. Also, propose to rename stringlock to keylock

msftcoderdjw
msftcoderdjw previously approved these changes Aug 21, 2024
@msftcoderdjw msftcoderdjw merged commit 7872c4a into eclipse-symphony:main Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants